Bug 2087750

Summary:	irqbalance unit file - /path/to dummy filename
Product:	Red Hat Enterprise Linux 9	Reporter:	Jan Pazdziora (Red Hat) <jpazdziora>
Component:	irqbalance	Assignee:	ltao
Status:	CLOSED DUPLICATE	QA Contact:	Jiri Dluhos <jdluhos>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	9.0	CC:	bugzilla_acct_1959, extras-qa, jdluhos, jeder, jpazdziora, jshortt, nhorman, rvr, walters, zbyszek
Target Milestone:	rc	Keywords:	Regression
Target Release:	---	Flags:	pm-rhel: mirror+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	2007761	Environment:
Last Closed:	2022-05-20 12:32:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2007761, 2058510
Bug Blocks:

Description Jan Pazdziora (Red Hat) 2022-05-18 12:39:20 UTC

+++ This bug was initially created as a clone of Bug #2007761 +++

Description of problem:

See https://bugzilla.redhat.com/show_bug.cgi?id=1952715#c8 which is still uncorrected and marked as needing info (though it appears no info is needed).
This problem still exists in Fedora 35 (Fedora-35-20210924.n.0).

The systemd unit file for irqbalance has the line:

EnvironmentFile=-/path/to/irqbalance.env

This /path/to was clearly intended to be a place-holder. It should refer to the local /etc config file, so:

EnvironmentFile=-/etc/sysconfig/irqbalance

--------

Also, the irqbalance service still, in Fedora 35, gives the journal error:

libcap-ng used by "/usr/sbin/irqbalance" failed due to not having CAP_SETPCAP in capng_apply

and, as referred to in the bugzilla linked above, can be corrected by this line in the unit file:

CapabilityBoundingSet=CAP_SETPCAP




Version-Release number of selected component (if applicable):

irqbalance-1.7.0-8.fc35

How reproducible:

Always.

Steps to Reproduce:
1.
2.
3.

Actual results:

Local config file /etc/sysconfig/irqbalance ignored.

Error message re CAP_SETPCAP given.


Expected results:

Local config file /etc/sysconfig/irqbalance *NOT* ignored.

*NO* error message re CAP_SETPCAP.

Additional info:

--- Additional comment from Zbigniew Jędrzejewski-Szmek on 2021-10-13 09:07:43 CEST ---

#1952715 describes the second issue sufficiently.

Comment 1 Jan Pazdziora (Red Hat) 2022-05-18 12:46:26 UTC

The issue is present on RHEL 9.0 as well:

# rpm -q irqbalance
irqbalance-1.8.0-4.el9.x86_64
# grep EnvironmentFile /usr/lib/systemd/system/irqbalance.service
EnvironmentFile=-/usr/lib/irqbalance/defaults.env
EnvironmentFile=-/path/to/irqbalance.env

Sourcing configuration from location which does exist and is not part of Filesystem Hierarchy Standard has a potential of affecting behaviour of this root-executing daemon in unexpected ways.

This is a regression against RHEL 8:

# rpm -q irqbalance
irqbalance-1.4.0-6.el8.x86_64
# grep EnvironmentFile /usr/lib/systemd/system/irqbalance.service
EnvironmentFile=/etc/sysconfig/irqbalance

Comment 2 Jan Pazdziora (Red Hat) 2022-05-18 12:48:47 UTC

The correct patch seems to have been lost from .spec in Fedora 33:

https://src.fedoraproject.org/rpms/irqbalance/c/76add4e1b859699ad90e6438dd6362a284191b93?branch=rawhide

Comment 3 ltao 2022-05-20 02:27:59 UTC

Hi Jan,

I think this bz is duplicated to bz2058509, which has been fixed in irqbalance-1.8.0-5.el9. Hi Jiri, bz2058509 is currently in modified status, could you please have a test on it? I can then add the build in to errata after the bz verified tested, which then can be integrated into nightly compose.

Thanks,
Tao Liu

Comment 4 Jan Pazdziora (Red Hat) 2022-05-20 12:32:11 UTC

Sorry for having missed the already opened RHEL 9 bugzilla, marking as duplicate.

*** This bug has been marked as a duplicate of bug 2058509 ***