Bug 2089418

Summary:	[Rebase] Rebase boom-boot to version 1.4
Product:	Red Hat Enterprise Linux 9	Reporter:	Marian Csontos <mcsontos>
Component:	boom-boot	Assignee:	Marian Csontos <mcsontos>
Status:	CLOSED ERRATA	QA Contact:	cluster-qe <cluster-qe>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	9.1	CC:	agk, bmr, cmarthal, jbrassow, mcsontos
Target Milestone:	rc	Keywords:	Rebase, Triaged
Target Release:	---	Flags:	pm-rhel: mirror+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	boom-boot-1.4-4.el9	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-11-15 10:36:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Marian Csontos 2022-05-23 15:52:08 UTC

boom-boot 1.4 brings one new feature: stratis volume handling.

Other notable changes are:

- removing of boom-boot-grub2 subpackage, which is now obsolete. With BLS the default, it is not needed anymore,

- removing profiles from package - these are user data, and should be generated by user and not by package. This should not affect existing boot entries, but user may need to recreate profiles for old entries if they need to be modified.

Comment 6 Marian Csontos 2022-06-13 13:11:19 UTC

Eh, the CI tested 1.4-3 but FixedInVersion was kept at an old 1.4-1.
I upgraded FixedInVersion to the version with profiles directory packaged, Corey, could you retest, please?

Comment 8 Corey Marthaler 2022-06-13 20:51:41 UTC

These are the two issues QA continues to see that are blocking verification:

https://bugzilla.redhat.com/show_bug.cgi?id=2096447
https://bugzilla.redhat.com/show_bug.cgi?id=2096368

All of our other tests are now passing.

Comment 14 Corey Marthaler 2022-07-19 16:14:12 UTC

Marking verified in with the latest rpms.

boom-boot-1.4-4.el9    BUILT: Thu Jul 14 01:20:05 AM CDT 2022


SCENARIO - [boom_sanity]
Create a snapshot and perform some boom sanity only checks as this wont be an actual bootable snapshot
Installing package boom-boot on hayes-03...
Package boom-boot installed on node hayes-03.
Making origin volume
lvcreate --yes -L 300M snapper -n origin
Making snapshot of origin volume
lvcreate --yes -s /dev/snapper/origin -c 128 -n boom_snap -L 100M

Check 0 a. Verify a new profile can be created (this is basically a dup of the above cmd)
boom profile create --from-host --uname-pattern Linux
Check 0 b. Verify a new profile can be created automatically from just current host heuristic
boom profile create --from-host
Check 0 c. Verify a new profile can be created
boom profile create --from-host --uname-pattern el9

Check 1. Verify blscfg is configured w/ grub and boom (New in RHEL9.1, we are no longer concerned w/ boom in grub.cfg)
Generating grub configuration file ...
Found Red Hat Enterprise Linux 9.1 Beta (Plow) on /dev/sdc3
Adding boot menu entry for UEFI Firmware Settings ...
done

Check 2 a. Verify version numbers not matching an OS profile provide a helpful warning (Bug 1771584#c5)
boom create --title nomatchversion --rootlv snapper/boom_snap --version 2.5.0
Check 2 b. Verify fake OS profiles are properly identified (Bug 1540266)
boom create --profile fake_profile --title title --version 3.10-272.el7 --rootlv snapper/boom_snap

Check 3. Verify --rootlv and --root-device variations are both accepted (Bug 1543188)
[--rootlv]: boom create --title 1 --rootlv /dev/snapper/boom_snap
boom list da3ee15
BootID  Version                  Name                     RootDevice            
da3ee15 5.14.0-127.el9.x86_64    Red Hat Enterprise Linux /dev/snapper/boom_snap
boom entry show da3ee15
Boot Entry (boot_id=da3ee15)
  title 1
  machine-id f59e551c77ff4b96901e02e6392ad713
  version 5.14.0-127.el9.x86_64
  linux /vmlinuz-5.14.0-127.el9.x86_64
  initrd /initramfs-5.14.0-127.el9.x86_64.img
  options root=/dev/snapper/boom_snap ro rd.lvm.lv=snapper/boom_snap
  grub_users $grub_users
  grub_arg --unrestricted
  grub_class kernel
boom delete da3ee15

[--root-lv]: boom create --title 2 --root-lv /dev/snapper/boom_snap
boom list cc507ec
BootID  Version                  Name                     RootDevice            
cc507ec 5.14.0-127.el9.x86_64    Red Hat Enterprise Linux /dev/snapper/boom_snap
boom entry show cc507ec
Boot Entry (boot_id=cc507ec)
  title 2
  machine-id f59e551c77ff4b96901e02e6392ad713
  version 5.14.0-127.el9.x86_64
  linux /vmlinuz-5.14.0-127.el9.x86_64
  initrd /initramfs-5.14.0-127.el9.x86_64.img
  options root=/dev/snapper/boom_snap ro rd.lvm.lv=snapper/boom_snap
  grub_users $grub_users
  grub_arg --unrestricted
  grub_class kernel
boom delete cc507ec

[--rootdevice]: boom create --title 3 --rootdevice /dev/snapper/boom_snap
boom list 17891cc
BootID  Version                  Name                     RootDevice            
17891cc 5.14.0-127.el9.x86_64    Red Hat Enterprise Linux /dev/snapper/boom_snap
boom entry show 17891cc
Boot Entry (boot_id=17891cc)
  title 3
  machine-id f59e551c77ff4b96901e02e6392ad713
  version 5.14.0-127.el9.x86_64
  linux /vmlinuz-5.14.0-127.el9.x86_64
  initrd /initramfs-5.14.0-127.el9.x86_64.img
  options root=/dev/snapper/boom_snap ro rd.lvm.lv=snapper/boom_snap
  grub_users $grub_users
  grub_arg --unrestricted
  grub_class kernel
boom delete 17891cc

[--root-device]: boom create --title 4 --root-device /dev/snapper/boom_snap
boom list 751da28
BootID  Version                  Name                     RootDevice            
751da28 5.14.0-127.el9.x86_64    Red Hat Enterprise Linux /dev/snapper/boom_snap
boom entry show 751da28
Boot Entry (boot_id=751da28)
  title 4
  machine-id f59e551c77ff4b96901e02e6392ad713
  version 5.14.0-127.el9.x86_64
  linux /vmlinuz-5.14.0-127.el9.x86_64
  initrd /initramfs-5.14.0-127.el9.x86_64.img
  options root=/dev/snapper/boom_snap ro rd.lvm.lv=snapper/boom_snap
  grub_users $grub_users
  grub_arg --unrestricted
  grub_class kernel
boom delete 751da28

Check 4. Verify --root-lv and --root-device verify the lv/device exists (Bug 1543186)
boom create --title no-lv --root-lv snapper/nonlv
boom create --title no-dev --root-device /dev/sdxyz
boom create --title 5 --no-dev --root-lv snapper/nonlv
boom delete 7830ae7

Check 5. Verify proper use of user providing --rootlv /dev/* format (Bug 1544914)
boom create --title 6 --rootlv /dev/snapper/boom_snap
Created entry with boot_id c01aaf0:
  title 6
  machine-id f59e551c77ff4b96901e02e6392ad713
  version 5.14.0-127.el9.x86_64
  linux /vmlinuz-5.14.0-127.el9.x86_64
  initrd /initramfs-5.14.0-127.el9.x86_64.img
  options root=/dev/snapper/boom_snap ro rd.lvm.lv=snapper/boom_snap
  grub_users $grub_users
  grub_arg --unrestricted
  grub_class kernel
boom delete c01aaf0

Check 6. Verify proper rd.lvm.lv entry w/ --root-device option (Also listed in Bug 1544914)
boom create --title 7 --root-device /dev/snapper/boom_snap
Created entry with boot_id aa1ed0e:
  title 7
  machine-id f59e551c77ff4b96901e02e6392ad713
  version 5.14.0-127.el9.x86_64
  linux /vmlinuz-5.14.0-127.el9.x86_64
  initrd /initramfs-5.14.0-127.el9.x86_64.img
  options root=/dev/snapper/boom_snap ro rd.lvm.lv=snapper/boom_snap
  grub_users $grub_users
  grub_arg --unrestricted
  grub_class kernel
regression check for bug 1840488
boom remove aa1ed0e
boom delete aa1ed0e

Check 7. Verify --grub-arg, grub-class, grub-users, and grub-id specified arguments (r7 rfe 1777364 / r8 rfe 1848123)
[--grub-arg]: boom create --title 10 --grub-arg 521 --root-lv /dev/snapper/boom_snap
boom list 069f624 --expand-variables
BootID  Version                  Name                     RootDevice            
069f624 5.14.0-127.el9.x86_64    Red Hat Enterprise Linux /dev/snapper/boom_snap
grub val not found in expanded list output (possible regression of bug 1840337)
boom entry show 069f624
Boot Entry (boot_id=069f624)
  title 10
  machine-id f59e551c77ff4b96901e02e6392ad713
  version 5.14.0-127.el9.x86_64
  linux /vmlinuz-5.14.0-127.el9.x86_64
  initrd /initramfs-5.14.0-127.el9.x86_64.img
  options root=/dev/snapper/boom_snap ro rd.lvm.lv=snapper/boom_snap
  grub_users $grub_users
  grub_arg 521
  grub_class kernel
boom delete 069f624

[--grub-class]: boom create --title 11 --grub-class 259 --root-lv /dev/snapper/boom_snap
boom list 4e17890 --expand-variables
BootID  Version                  Name                     RootDevice            
4e17890 5.14.0-127.el9.x86_64    Red Hat Enterprise Linux /dev/snapper/boom_snap
grub val not found in expanded list output (possible regression of bug 1840337)
boom entry show 4e17890
Boot Entry (boot_id=4e17890)
  title 11
  machine-id f59e551c77ff4b96901e02e6392ad713
  version 5.14.0-127.el9.x86_64
  linux /vmlinuz-5.14.0-127.el9.x86_64
  initrd /initramfs-5.14.0-127.el9.x86_64.img
  options root=/dev/snapper/boom_snap ro rd.lvm.lv=snapper/boom_snap
  grub_users $grub_users
  grub_arg --unrestricted
  grub_class 259
boom delete 4e17890

[--grub-users]: boom create --title 12 --grub-users 975 --root-lv /dev/snapper/boom_snap
boom list 3cc99c1 --expand-variables
BootID  Version                  Name                     RootDevice            
3cc99c1 5.14.0-127.el9.x86_64    Red Hat Enterprise Linux /dev/snapper/boom_snap
grub val not found in expanded list output (possible regression of bug 1840337)
boom entry show 3cc99c1
Boot Entry (boot_id=3cc99c1)
  title 12
  machine-id f59e551c77ff4b96901e02e6392ad713
  version 5.14.0-127.el9.x86_64
  linux /vmlinuz-5.14.0-127.el9.x86_64
  initrd /initramfs-5.14.0-127.el9.x86_64.img
  options root=/dev/snapper/boom_snap ro rd.lvm.lv=snapper/boom_snap
  grub_users 975
  grub_arg --unrestricted
  grub_class kernel
boom delete 3cc99c1

Removing volume snapper/boom_snap
Removing origin snapper/origin

Comment 19 errata-xmlrpc 2022-11-15 10:36:23 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (boom-boot bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:8205