Bug 2091776
| Summary: | Review Request: astral - Go calculations for the position of the sun and moon | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Link Dupont <link> |
| Component: | Package Review | Assignee: | Maxwell G <maxwell> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | maxwell, package-review |
| Target Milestone: | --- | Flags: | maxwell:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-06-20 04:36:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2092180 | ||
|
Description
Link Dupont
2022-05-31 03:43:46 UTC
I am not going to go through the whole fedora-review template, as this package uses go2rpm.
- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [x] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.
The guidelines recommend removing the glob for `%{_bindir}/*` in %files, but you can fix that on import.
Package approved! On import, don't forget to do the following:
- [ ] Add package to release-monitoring.org
- [ ] Add package to Koschei.
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket.
Thanks!
> Fedora Review: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-36-x86_64/04459530-astral/fedora-review/
It would've been nice if I'd seen this before I went and ran fedora-review myself :(.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/astral FEDORA-2022-7a355af762 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-7a355af762 FEDORA-2022-7a355af762 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. |