Bug 2091776 - Review Request: astral - Go calculations for the position of the sun and moon
Summary: Review Request: astral - Go calculations for the position of the sun and moon
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Maxwell G
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2092180
TreeView+ depends on / blocked
 
Reported: 2022-05-31 03:43 UTC by Link Dupont
Modified: 2022-06-20 04:36 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-06-20 04:36:46 UTC
Type: ---
Embargoed:
maxwell: fedora-review+


Attachments (Terms of Use)

Comment 1 Maxwell G 2022-06-17 22:59:45 UTC
I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [x] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.
  The guidelines recommend removing the glob for `%{_bindir}/*` in %files, but you can fix that on import.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Add package to Koschei.
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket.

Thanks!

Comment 2 Maxwell G 2022-06-17 23:02:09 UTC
> Fedora Review: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-36-x86_64/04459530-astral/fedora-review/

It would've been nice if I'd seen this before I went and ran fedora-review myself :(.

Comment 3 Kevin Fenzi 2022-06-19 22:37:00 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/astral

Comment 4 Fedora Update System 2022-06-20 04:35:09 UTC
FEDORA-2022-7a355af762 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-7a355af762

Comment 5 Fedora Update System 2022-06-20 04:36:46 UTC
FEDORA-2022-7a355af762 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.