Bug 2092471

Summary:	Review Request: rust-kvm-bindings - Rust FFI bindings to KVM generated using bindgen
Product:	[Fedora] Fedora	Reporter:	Sergio Lopez <slopezpa>
Component:	Package Review	Assignee:	Cole Robinson <crobinso>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	crobinso, fabiano, package-review
Target Milestone:	---	Flags:	crobinso: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-06-17 11:37:41 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sergio Lopez 2022-06-01 16:07:08 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/slp/rust-kvm-bindings/fedora-rawhide-x86_64/04489303-rust-kvm-bindings/rust-kvm-bindings.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/slp/rust-kvm-bindings/fedora-rawhide-x86_64/04489303-rust-kvm-bindings/rust-kvm-bindings-0.5.0-1.fc37.src.rpm
Description:
Rust FFI bindings to KVM generated using bindgen

Fedora Account System Username: slp

Comment 1 Cole Robinson 2022-06-05 17:44:10 UTC

Boilerplate rust package. fedora-review and manual inspection didn't flag anything interesting.

scratch-build shows i686 isn't building. IMO it's fine to disable i686 according to https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval

I just tested and ExclusiveArch + ExcludeArch works fine. So before pushing slap a `ExcludeArch: %{ix86}` in there with a comment explaining why

Setting fedora-review+

Comment 2 Sergio Lopez 2022-06-06 05:13:14 UTC

(In reply to Cole Robinson from comment #1)
> I just tested and ExclusiveArch + ExcludeArch works fine. So before pushing
> slap a `ExcludeArch: %{ix86}` in there with a comment explaining why

Will do that. Thanks a lot for the review!

Comment 3 Gwyn Ciesla 2022-06-06 19:42:46 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-kvm-bindings

Comment 4 Sergio Lopez 2022-06-17 11:37:41 UTC

The package has hit rawhide, thanks Cole and Gwyn!