Bug 2092471 - Review Request: rust-kvm-bindings - Rust FFI bindings to KVM generated using bindgen
Summary: Review Request: rust-kvm-bindings - Rust FFI bindings to KVM generated using ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Cole Robinson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-06-01 16:07 UTC by Sergio Lopez
Modified: 2022-06-17 11:37 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-06-17 11:37:41 UTC
Type: ---
Embargoed:
crobinso: fedora-review+


Attachments (Terms of Use)

Comment 1 Cole Robinson 2022-06-05 17:44:10 UTC
Boilerplate rust package. fedora-review and manual inspection didn't flag anything interesting.

scratch-build shows i686 isn't building. IMO it's fine to disable i686 according to https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval

I just tested and ExclusiveArch + ExcludeArch works fine. So before pushing slap a `ExcludeArch: %{ix86}` in there with a comment explaining why

Setting fedora-review+

Comment 2 Sergio Lopez 2022-06-06 05:13:14 UTC
(In reply to Cole Robinson from comment #1)
> I just tested and ExclusiveArch + ExcludeArch works fine. So before pushing
> slap a `ExcludeArch: %{ix86}` in there with a comment explaining why

Will do that. Thanks a lot for the review!

Comment 3 Gwyn Ciesla 2022-06-06 19:42:46 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-kvm-bindings

Comment 4 Sergio Lopez 2022-06-17 11:37:41 UTC
The package has hit rawhide, thanks Cole and Gwyn!


Note You need to log in before you can comment on or make changes to this bug.