Bug 2093465
| Summary: | Review Request: gmailctl - Declarative configuration for Gmail filters | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mark E. Fuller <mark.e.fuller> |
| Component: | Package Review | Assignee: | Mikel Olasagasti Uranga <mikel> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mikel, package-review |
| Target Milestone: | --- | Flags: | mikel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | trivial | ||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-06-16 16:44:07 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Mark E. Fuller
2022-06-03 19:27:53 UTC
Spec is correct, but before approving it two questions: - Wouldn't it better to call package directly `gmailctl` rather than `golang-github-mbrt-gmailctl`? If you want so, define the following global: %global goname gmailctl Rename the spec to gmailctl.spec and change this BZ's title. You can check `doctl` as an example. - You defined all the BuildRequires rather than using `%go_generate_buildrequires`. In some of your other specs you're using that macro, maybe you want to change this spec to use dynamic BuildRequires? Thanks for the suggestions and for the review Re: BuildRequires, I had thought when I made up the spec that I was getting an error about a name mismatch when generating the requirements automatically - that isn't happening anymore. Updated files: Spec URL: https://fuller.fedorapeople.org/gmailctl.spec SRPM URL: https://fuller.fedorapeople.org/gmailctl-0.10.4-1.fc36.src.rpm go2rpm package, fedora-review is correct: - The specfile is sane - License is correct - Builds successfully in mock - No rpmlint errors - %check section passes - The latest version is packaged - The package complies with the Packaging Guidelines Package approved! On import, don't forget to do the following: - Add package to release-monitoring.org - Add package to Koschei. - Give go-sig privileges on package - Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket. (rhbz#BUG_ID) Thanks! (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gmailctl |