Bug 2097813

This package is a new optional BR: of perl-Sub-HandlesVia.

Updated package:
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-MooseX-Extended.spec
SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-MooseX-Extended-0.25-1.fc37.src.rpm

Updated package:
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-MooseX-Extended.spec
SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-MooseX-Extended-0.28-1.fc38.src.rpm

Updated package:
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-MooseX-Extended.spec
SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-MooseX-Extended-0.34-1.fc38.src.rpm

There are issues:
* Remove COMPAT line (with coreutils dependency, which is used for echo in COMPAT line)

Optional:
* I am for adding comments like "Runtime:" and "Tests:" to BuildRequire list as in other Perl modules

Sorry coreutils is needed for %{_fixperms}

(In reply to Michal Josef Spacek from comment #6)
> Sorry coreutils is needed for %{_fixperms}
Correct. Misinterpretations such as yours are the result of RHAT's ban of file deps. Incidents like this demonstrate this ban's harmfulness.

Updated package:
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-MooseX-Extended.spec
SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-MooseX-Extended-0.35-1.fc39.src.rpm

Hi Ralf,

There is one missing thing with not explicitly named files in spec file.
Need to name files in %{perl_vendorlib}/ and %{_mandir}/man3/
See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists

Other seems ok.

(In reply to Michal Josef Spacek from comment #8)
> Hi Ralf,
> 
> There is one missing thing with not explicitly named files in spec file.
> Need to name files in %{perl_vendorlib}/ and %{_mandir}/man3/
Hundreds of perl-packages use %{perl_vendorlib}/* and %{_mandir}/man3/*

I refuse to apply your suggestion.

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-MooseX-Extended-0.35-1.fc39.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(B::Hooks::AtRuntime)
      1 perl(Carp)
      1 perl(constant)
      1 perl(Exporter)
      1 perl(feature)
      1 perl(Import::Into)
      1 perl-libs
      1 perl(Module::Load)
      1 perl(Moose)
      1 perl(Moose::Exporter)
      1 perl(Moose::Meta::Role)
      1 perl(Moose::Role)
      1 perl(Moose::Util)
      1 perl(MooseX::Extended)
      1 perl(MooseX::Extended::Core)
      1 perl(MooseX::Extended::Role)
      1 perl(MooseX::Extended::Types)
      1 perl(MooseX::Role::WarnOnConflict)
      1 perl(MooseX::StrictConstructor)
      1 perl(mro)
      1 perl(namespace::autoclean)
      1 perl(parent)
      1 perl(Ref::Util)
      1 perl(Storable)
      1 perl(strict)
      1 perl(true)
      1 perl(Type::Library)
      1 perl(Type::Params)
      1 perl(Types::Standard)
      1 perl(Type::Utils)
      1 perl(:VERSION) >= 5.20.0
      1 perl(warnings)

Binary requires are Ok.

$ rpm -qp --provides perl-MooseX-Extended-0.35-1.fc39.noarch.rpm | sort | uniq -c
      1 perl(Moose::Exception::InvalidAttributeDefinition) = 0.35
      1 perl(Moose::Exception::InvalidImportList) = 0.35
      1 perl(MooseX::Extended::Core) = 0.35
      1 perl(MooseX::Extended::Custom) = 0.35
      1 perl(MooseX::Extended::Role::Custom) = 0.35
      1 perl(MooseX::Extended::Role) = 0.35
      1 perl(MooseX::Extended::Types) = 0.35
      1 perl(MooseX::Extended) = 0.35
      1 perl-MooseX-Extended = 0.35-1.fc39

Binary provides are Ok.

$ rpmlint perl-MooseX-Extended-0.35-1.fc39.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.0 s
Rpmlint is ok

The package is in line with Fedora and Perl packaging guide lines.

Resolution:
The package can be approved.