Bug 2097799 - Review Request: perl-B-Hooks-AtRuntime - Lower blocks from compile time to runtime
Summary: Review Request: perl-B-Hooks-AtRuntime - Lower blocks from compile time to ru...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2097759
Blocks: 2097813
TreeView+ depends on / blocked
 
Reported: 2022-06-16 15:07 UTC by Ralf Corsepius
Modified: 2022-07-14 15:04 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-07-14 15:04:12 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Ralf Corsepius 2022-06-16 15:07:47 UTC
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-B-Hooks-AtRuntime.spec
SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-B-Hooks-AtRuntime-6-1.fc37.src.rpm
Description:
This module allows code that runs at compile-time to do something at
runtime. A block passed to at_runtime gets compiled into the code that's
currently compiling, and will be called when control reaches that point
at runtime. In the example in the SYNOPSIS, the warnings will occur in
order, and if that section of code runs more than once, so will all
three warnings.

Fedora Account System Username: corsepiu

Comment 2 Jitka Plesnikova 2022-07-12 13:59:51 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires
FIX: Use 'perl(:VERSION) >= 5.8.1' instead of 'perl >= 0:5.008001' because
     the package has an epoch.
FIX: Please add build-requires:
     coreutils - needed for macro %{_fixperms}
     findutils - spec file line 47
     perl(Carp) - lib/B/Hooks/AtRuntime.pm:8
     perl(constant) - lib/B/Hooks/AtRuntime.pm:19
     perl(lib) - t/00use.t:5
     perl(Exporter) - tlib/t/Util.pm:6
     perl(strict) - lib/B/Hooks/AtRuntime.pm:4
     perl(warnings) - lib/B/Hooks/AtRuntime.pm:3
     perl(XSLoader) - lib/B/Hooks/AtRuntime.pm:6

$ rpm -qp --requires perl-B-Hooks-AtRuntime-7-1.fc37.x86_64.rpm | sort | uniq -c | grep -v rpmlib
      1 ld-linux-x86-64.so.2()(64bit)
      1 ld-linux-x86-64.so.2(GLIBC_2.3)(64bit)
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 perl(Carp)
      1 perl(constant)
      1 perl(Exporter::Tiny)
      1 perl(:MODULE_COMPAT_5.36.0)
      1 perl(parent)
      1 perl(strict)
      1 perl(Sub::Name)
      1 perl(warnings)
      1 perl(XSLoader)
      1 rtld(GNU_HASH)
Binary requires 
FIX: Please add run-requires
     perl(Filter::Util::Call) - lib/B/Hooks/AtRuntime.pm:25

$ rpm -qp --provides perl-B-Hooks-AtRuntime-7-1.fc37.x86_64.rpm | sort | uniq -c
      1 perl(B::Hooks::AtRuntime) = 7
      1 perl-B-Hooks-AtRuntime = 7-1.fc37
      1 perl-B-Hooks-AtRuntime(x86-64) = 7-1.fc37
Binary provides are Ok.

$ rpmlint ./perl-B-Hooks-AtRuntime*
================================= rpmlint session starts ================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
== 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s =
Rpmlint is ok

TODO: I think 'Build', 'META.json' and the test directory 'tlib' could be
      removed from %doc.

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items, consider fixing 'TODO' item and provide a new spec file.

Resolution:
Not approved

Comment 4 Jitka Plesnikova 2022-07-14 07:43:09 UTC
It looks good.

Resolution: Approved

Comment 5 Gwyn Ciesla 2022-07-14 13:59:06 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-B-Hooks-AtRuntime

Comment 6 Ralf Corsepius 2022-07-14 15:04:12 UTC
Thanks for the review.


Note You need to log in before you can comment on or make changes to this bug.