Bug 2101953

Summary: [RFE] efi shell detection
Product: [Fedora] Fedora Reporter: Pat Riehecky <riehecky>
Component: os-proberAssignee: Hedayat Vatankhah <hedayatv>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: agk, hedayatv
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: os-prober-1.81-1.fc37 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 2103180 2104000 (view as bug list) Environment:
Last Closed: 2022-08-06 21:09:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2104000    
Attachments:
Description Flags
script to detect none

Description Pat Riehecky 2022-06-28 21:56:06 UTC 
Description of problem:

os-probes/mounted/x86/efi contains some helpful scripts for matching EFI applications.

Can a new probe be added for 'shell.efi'?  I'd leave it as an exercise to the sysadmin to ensure they've got the right sort of shell binary (IA32/IA64).  But this would make it easy to add an entry for the EFI shell on systems that don't ship a builtin efi shell.

Version-Release number of selected component (if applicable):os-prober-1.77-9.fc36.x86_64


How reproducible:
100%

Steps to Reproduce:
1. Try to get '[sS]hell.efi' detected like elilo
2. 
3.

Actual results:
Only elilo or microsoft are currently detected

Expected results:
detection of an efi shell

Additional info:

I'd be happy to submit a patch upstream if I could figure out where to route it....
Comment 1 Pat Riehecky 2022-07-01 15:27:54 UTC 
Created attachment 1893933 [details]
script to detect
Comment 2 Hedayat Vatankhah 2022-07-01 20:51:05 UTC 
It'd be great if you submit the patch upstream. For it, you can use Debian bug tracker and fill a report with patch for os-prober package.
Comment 3 Pat Riehecky 2022-07-03 17:29:50 UTC 
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1014302
Comment 4 Pat Riehecky 2022-07-15 14:49:45 UTC 
https://salsa.debian.org/installer-team/os-prober/-/merge_requests/18
Comment 5 Hedayat Vatankhah 2022-07-20 21:54:25 UTC 
Thank you for submitting the changes upstream. That's great, although I'm not sure if they'll act fast. I'll review your changes and I might incorporate it in Fedora if it seems fine even before being merged upstream.
Comment 6 Pat Riehecky 2022-07-25 13:09:11 UTC 
Awesome!  My longterm goal is CentOS Stream 9, but I understand putting it into Fedora first.
Comment 7 Fedora Update System 2022-08-06 21:08:59 UTC 
FEDORA-2022-90f3eaf5b2 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-90f3eaf5b2
Comment 8 Fedora Update System 2022-08-06 21:09:37 UTC 
FEDORA-2022-90f3eaf5b2 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.