Bug 2101953 - [RFE] efi shell detection
Summary: [RFE] efi shell detection
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: os-prober
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Hedayat Vatankhah
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2104000
TreeView+ depends on / blocked
 
Reported: 2022-06-28 21:56 UTC by Pat Riehecky
Modified: 2022-08-06 21:09 UTC (History)
2 users (show)

Fixed In Version: os-prober-1.81-1.fc37
Clone Of:
: 2103180 2104000 (view as bug list)
Environment:
Last Closed: 2022-08-06 21:09:37 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
script to detect (478 bytes, text/plain)
2022-07-01 15:27 UTC, Pat Riehecky
no flags Details

Description Pat Riehecky 2022-06-28 21:56:06 UTC
Description of problem:

os-probes/mounted/x86/efi contains some helpful scripts for matching EFI applications.

Can a new probe be added for 'shell.efi'?  I'd leave it as an exercise to the sysadmin to ensure they've got the right sort of shell binary (IA32/IA64).  But this would make it easy to add an entry for the EFI shell on systems that don't ship a builtin efi shell.

Version-Release number of selected component (if applicable):os-prober-1.77-9.fc36.x86_64


How reproducible:
100%

Steps to Reproduce:
1. Try to get '[sS]hell.efi' detected like elilo
2. 
3.

Actual results:
Only elilo or microsoft are currently detected

Expected results:
detection of an efi shell

Additional info:

I'd be happy to submit a patch upstream if I could figure out where to route it....

Comment 1 Pat Riehecky 2022-07-01 15:27:54 UTC
Created attachment 1893933 [details]
script to detect

Comment 2 Hedayat Vatankhah 2022-07-01 20:51:05 UTC
It'd be great if you submit the patch upstream. For it, you can use Debian bug tracker and fill a report with patch for os-prober package.

Comment 5 Hedayat Vatankhah 2022-07-20 21:54:25 UTC
Thank you for submitting the changes upstream. That's great, although I'm not sure if they'll act fast. I'll review your changes and I might incorporate it in Fedora if it seems fine even before being merged upstream.

Comment 6 Pat Riehecky 2022-07-25 13:09:11 UTC
Awesome!  My longterm goal is CentOS Stream 9, but I understand putting it into Fedora first.

Comment 7 Fedora Update System 2022-08-06 21:08:59 UTC
FEDORA-2022-90f3eaf5b2 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-90f3eaf5b2

Comment 8 Fedora Update System 2022-08-06 21:09:37 UTC
FEDORA-2022-90f3eaf5b2 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.