Bug 210285
Summary: | Review Request: kfolding - KDE kicker applet for Folding@home | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Matěj Cepl <mcepl> |
Component: | Package Review | Assignee: | Petr Rockai <prockai> |
Status: | CLOSED CANTFIX | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | mcepl, rdieter, tmraz |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-10-20 09:14:30 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 201449 |
Description
Matěj Cepl
2006-10-11 10:57:45 UTC
The new srpm looks good to me, only few little issues: 75 %{_datadir}/apps/kfolding/pics/ is redundant and 84 * Wed Oct 11 2006 Matej Cepl <mcepl> - 1.0.0-rc2 has wrong version number (should be version-release, that is 1.0.0-0.rc2). rpmlint says E: kfolding file-in-usr-marked-as-conffile /usr/share/apps/kfolding/default.cfg W: kfolding symlink-should-be-relative /usr/share/doc/HTML/en/kfolding/common /usr/share/doc/HTML/en/common The default.cfg file probably shouldn't be marked conffile, the program, if i understand correctly, should create ~/.kde/share/apps/kfolding/default.cfg for user to modify, the file in /usr is just a set of system-wide defaults. The symlink should be relativized to ../common. I have tried to not miss anything this time, hope it's really all :). I am not able to fix this: [matej@localhost redhat]$ rpmlint -i RPMS/i386/kfolding-1.0.0-1.rc2.i386.rpm W: kfolding dangling-relative-symlink /usr/share/doc/HTML/en/kfolding/common ../common The relative symbolic link points nowhere. Otherwise above mentioned problems are fixed, and the new URL for SRPM is http://www.ceplovi.cz/matej/progs/rpms/kfolding-1.0.0-1.rc2.src.rpm What should I do now? The symlink is OK, the target is present in a package that is Required. Looks good now, i let tmraz take over here. %find_lang %{name} is present however the lang file is not included in the filelist. Hopefully, finally cleaned up. URLs are the same. I had to switch to Gnome for my work, so I won't package any KDE-related packages anymore. |