Bug 210285 - Review Request: kfolding - KDE kicker applet for Folding@home
Review Request: kfolding - KDE kicker applet for Folding@home
Status: CLOSED CANTFIX
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Petr Rockai
Fedora Package Reviews List
:
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2006-10-11 06:57 EDT by Matěj Cepl
Modified: 2007-11-30 17:11 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-10-20 05:14:30 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description Matěj Cepl 2006-10-11 06:57:45 EDT
Spec URL: http://www.ceplovi.cz/matej/progs/rpms/kfolding.spec
SRPM URL: http://www.ceplovi.cz/matej/progs/rpms/kfolding-1.0.0_rc2-1.src.rpm
Description: Folding@home Applet is an applet for the KDE panel. It provides a convenient and unobtrusive way to monitor, visualise, and control the Folding@home client software.

This is my first attempt to create an official package for Fedora (or any other RPM-based distribution for that matter) and I am seeking a sponsor.
Comment 1 Matěj Cepl 2006-10-11 08:02:40 EDT
SRPM URL is now 
http://www.ceplovi.cz/matej/progs/rpms/kfolding-1.0.0-0.rc2.src.rpm
Comment 2 Petr Rockai 2006-10-11 11:47:37 EDT
The new srpm looks good to me, only few little issues:
     75 %{_datadir}/apps/kfolding/pics/
is redundant and
     84 * Wed Oct 11 2006 Matej Cepl <mcepl@redhat.com> - 1.0.0-rc2
has wrong version number (should be version-release, that is 1.0.0-0.rc2).

rpmlint says
E: kfolding 
file-in-usr-marked-as-conffile /usr/share/apps/kfolding/default.cfg
W: kfolding 
symlink-should-be-relative /usr/share/doc/HTML/en/kfolding/common /usr/share/doc/HTML/en/common

The default.cfg file probably shouldn't be marked conffile, the program, if i 
understand correctly, should create ~/.kde/share/apps/kfolding/default.cfg for 
user to modify, the file in /usr is just a set of system-wide defaults.

The symlink should be relativized to ../common.

I have tried to not miss anything this time, hope it's really all :).
Comment 3 Matěj Cepl 2006-10-12 08:24:41 EDT
I am not able to fix this:

[matej@localhost redhat]$ rpmlint -i RPMS/i386/kfolding-1.0.0-1.rc2.i386.rpm
W: kfolding 
dangling-relative-symlink /usr/share/doc/HTML/en/kfolding/common ../common
The relative symbolic link points nowhere.

Otherwise above mentioned problems are fixed, and the new URL for SRPM is 
http://www.ceplovi.cz/matej/progs/rpms/kfolding-1.0.0-1.rc2.src.rpm

What should I do now?
Comment 4 Petr Rockai 2006-10-12 10:00:35 EDT
The symlink is OK, the target is present in a package that is Required. Looks
good now, i let tmraz take over here.
Comment 5 Tomas Mraz 2006-10-12 11:02:47 EDT
%find_lang %{name} is present however the lang file is not included in the filelist.
Comment 6 Matěj Cepl 2006-10-13 07:38:50 EDT
Hopefully, finally cleaned up. URLs are the same.
Comment 7 Matěj Cepl 2006-10-20 05:14:30 EDT
I had to switch to Gnome for my work, so I won't package any KDE-related
packages anymore.

Note You need to log in before you can comment on or make changes to this bug.