Bug 2103475

Summary:	Review Request: rust-argmax - Rust library to deal with 'argument too long' errors
Product:	[Fedora] Fedora	Reporter:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-07-18 14:07:45 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2027038

Description Zbigniew Jędrzejewski-Szmek 2022-07-03 17:09:04 UTC

Spec URL: https://in.waw.pl/~zbyszek/fedora/rust-argmax.spec
SRPM URL: https://in.waw.pl/~zbyszek/fedora/rust-argmax-0.3.0-1.fc37.src.rpm
Description:
Rust library to deal with 'argument too long' errors.

Fedora Account System Username: zbyszek

Comment 1 Fabio Valentini 2022-07-16 19:58:48 UTC

Looks good to me. You might want to poke upstream to upgrade to nix 0.24.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 2 Zbigniew Jędrzejewski-Szmek 2022-07-18 14:07:45 UTC

Thanks!

I can't build this right now because 'main' doesn't exist
(https://pagure.io/releng/issue/10903), but hopefully that'll be fixed soon.