Bug 2103475 - Review Request: rust-argmax - Rust library to deal with 'argument too long' errors
Summary: Review Request: rust-argmax - Rust library to deal with 'argument too long' e...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2027038
TreeView+ depends on / blocked
 
Reported: 2022-07-03 17:09 UTC by Zbigniew Jędrzejewski-Szmek
Modified: 2022-07-18 14:07 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-07-18 14:07:45 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Zbigniew Jędrzejewski-Szmek 2022-07-03 17:09:04 UTC
Spec URL: https://in.waw.pl/~zbyszek/fedora/rust-argmax.spec
SRPM URL: https://in.waw.pl/~zbyszek/fedora/rust-argmax-0.3.0-1.fc37.src.rpm
Description:
Rust library to deal with 'argument too long' errors.

Fedora Account System Username: zbyszek

Comment 1 Fabio Valentini 2022-07-16 19:58:48 UTC
Looks good to me. You might want to poke upstream to upgrade to nix 0.24.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 2 Zbigniew Jędrzejewski-Szmek 2022-07-18 14:07:45 UTC
Thanks!

I can't build this right now because 'main' doesn't exist
(https://pagure.io/releng/issue/10903), but hopefully that'll be fixed soon.


Note You need to log in before you can comment on or make changes to this bug.