Bug 2103477

This needs print_bytes>=0.4, which we apparently don't have.

According to upstream's README:

### Third-party software

This crate includes copies and modifications of software developed by third
parties:

- [src/cmp.rs] and [tests/rust.rs] contain modifications of code from The Rust
  Programming Language, licensed under the MIT License or the Apache License,
  Version 2.0.

- [src/common/localize/macos/fruity.rs] contains modifications of code from
  crate [fruity], licensed under the MIT License or the Apache License,
  Version 2.0.

See those files for more details.

Copies of third-party licenses can be found in [LICENSE-THIRD-PARTY].

I suppose these should have virtual Provides for `bundled(crate(fruity))` and `bundled(rust)`. The file headers have what commit hashes they were originally taken from, so you could use those as the version. The Rust Packaging Guidelines explicitly allow[1] bundling in this case.

[1]: https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_bundled_dependencies

(In reply to Maxwell G from comment #2)
> - [src/cmp.rs] and [tests/rust.rs] contain modifications of code from The
> Rust
>   Programming Language, licensed under the MIT License or the Apache License,
>   Version 2.0.

I added Provides:bundled(rust) for this. 
 
> - [src/common/localize/macos/fruity.rs] contains modifications of code from
>   crate [fruity], licensed under the MIT License or the Apache License,
>   Version 2.0.

This is only in git, the released version doesn't have it yet.

Thanks. Updated versions:
Spec URL: https://in.waw.pl/~zbyszek/fedora/rust-normpath.spec
SRPM URL: https://in.waw.pl/~zbyszek/fedora/rust-normpath-0.3.2-2.fc37.src.rpm

Hi Maxwell, do you want to proceed with the review, or should I take it over?

Feel free to just take it over. I deliberately didn't assign it to myself.

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

Two minor issues / warnings:

- If you're patching the print_bytes dependency, either bump it to plain "0.6" (which is what you have packaged),
  or, if you want to stay compatible with what upstream does, use ">=0.4,<0.7" instead.

  Using open-ended ">=0.4" is slightly dangerous, because it is compatible with *any* version higher than 0.4,
  which is probably not what you want (and which will also lead to very confusing error messages if the print_bytes crate ever changes its APIs).

- Make sure that you import the correct files into dist-git.
  The linked SRPM is already mangled by rpmautospec for some reason.

The repository for this package was created some time ago:
https://src.fedoraproject.org/rpms/rust-normpath

Looks like fedscm-admin just bugged out, didn't push an initial commit, and didn't comment here.
Please continue with importing the package.

*** Bug 2151234 has been marked as a duplicate of this bug. ***

https://pagure.io/fedora-infrastructure/issue/11035

FEDORA-EPEL-2023-856ea9cc50 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-856ea9cc50

FEDORA-2023-e38d8e2bfe has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e38d8e2bfe

FEDORA-EPEL-2023-856ea9cc50 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-856ea9cc50

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2023-b8692f75ba has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-b8692f75ba \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-b8692f75ba

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2023-e38d8e2bfe has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-e38d8e2bfe \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e38d8e2bfe

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2023-b8692f75ba has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2023-e38d8e2bfe has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-EPEL-2023-856ea9cc50 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.