Spec URL: https://in.waw.pl/~zbyszek/fedora/rust-print_bytes.spec SRPM URL: https://in.waw.pl/~zbyszek/fedora/rust-print_bytes-0.6.0-1.fc37.src.rpm Description: Print bytes as losslessly as possible. Fedora Account System Username: zbyszek
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/print_bytes-0.6.0/COPYRIGHT See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files This is a problem with rust2rpm and not necessarily something that can be fixed here. I suppose the best way to handle this for now would be to remove the license files and README from %{crate_instdir} in %install and just mark the relative paths with `%doc` and `%license` to install them in the usual locations. - 's/Patch0:/Patch: /'. Source isn't numbered and Patch doesn't need to be either. Numbering Sources and Patches is done automatically in modern RPM versions. rpmlint finds: rust-print_bytes.src: W: strange-permission rust-print_bytes.spec 600 NOTE: This should be fixed rust-print_bytes+default-devel.noarch: W: no-documentation rust-print_bytes+specialization-devel.noarch: W: no-documentation NOTE: spurious rust-print_bytes+default-devel.noarch: W: invalid-license Apache-2.0 rust-print_bytes+specialization-devel.noarch: W: invalid-license Apache-2.0 rust-print_bytes.src: W: invalid-license Apache-2.0 rust-print_bytes-devel.noarch: W: invalid-license Apache-2.0 NOTE: I assume you switched these to use SPDX identifiers now that that's been approved. The Change owners said[1] that's allowed now, but apparently rpmlint hasn't been updated. [1]: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/N2JPAJRXMVQ75G67V6YCHI74PX5KVGZ2/ Ctrl-F for NOTE for my other interspersed comments (2/3 are about fedora-review's output and not actual issues). All of the issues I pointed out are minor nitpicks and mostly the fault of rust2rpm, so package approved. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/cargo, /usr/share/cargo/registry NOTE: Owned by cargo [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. Handled by dependency generator [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. NOTE: ExclusiveArch to %{rust_arches} [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- print_bytes-devel , rust-print_bytes+default-devel , rust- print_bytes+specialization-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. NOTE: rust2rpm -p should probably give a more descriptive comment than "# Initial patched metadata", but oh well. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://crates.io/api/v1/crates/print_bytes/0.6.0/download#/print_bytes-0.6.0.crate : CHECKSUM(SHA256) this package : 3057e36886667c470305bb076abc7f2f77a5662cb8de4124a4f5e6206ad2acd7 CHECKSUM(SHA256) upstream package : 3057e36886667c470305bb076abc7f2f77a5662cb8de4124a4f5e6206ad2acd7 Requires -------- rust-print_bytes-devel (rpmlib, GLIBC filtered): cargo rust-print_bytes+default-devel (rpmlib, GLIBC filtered): cargo crate(print_bytes) rust-print_bytes+specialization-devel (rpmlib, GLIBC filtered): cargo crate(print_bytes) Provides -------- rust-print_bytes-devel: crate(print_bytes) rust-print_bytes-devel rust-print_bytes+default-devel: crate(print_bytes/default) rust-print_bytes+default-devel rust-print_bytes+specialization-devel: crate(print_bytes/specialization) rust-print_bytes+specialization-devel Diff spec file in url and in SRPM --------------------------------- --- /home/gotmax/Sync/git-repos/packaging/fedora_rpms/review.repos/2103480-rust-print_bytes/srpm/rust-print_bytes.spec 2022-07-03 16:40:28.275454159 -0500 +++ /home/gotmax/Sync/git-repos/packaging/fedora_rpms/review.repos/2103480-rust-print_bytes/srpm-unpacked/rust-print_bytes.spec 2022-07-03 12:21:43.000000000 -0500 @@ -1,2 +1,11 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.2.6) +%define autorelease(e:s:pb:) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{?dist} +## END: Set by rpmautospec + # Generated by rust2rpm 21 %bcond_without check @@ -85,3 +94,4 @@ %changelog -%autochangelog +* Sun Jul 03 2022 Zbigniew Jędrzejewski-Szmek <zbyszek.pl> 0.6.0-1 +- First version Related to rpmautospec. Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2103480 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Perl, Java, C/C++, Ocaml, PHP, Haskell, R, fonts, SugarActivity, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Also don't forget to perform the normal rust-sig post import tasks (taken from one of Fabio's reviews) Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches
(In reply to Maxwell G from comment #1) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > > Issues: > ======= > - Package does not contain duplicates in %files. > Note: warning: File listed twice: > /usr/share/cargo/registry/print_bytes-0.6.0/COPYRIGHT > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/#_duplicate_files > > This is a problem with rust2rpm and not necessarily something that can be > fixed here. > > I suppose the best way to handle this for now would be to remove the license > files and README from %{crate_instdir} in %install and just mark the relative > paths with `%doc` and `%license` to install them in the usual locations. This way of doing this was added on request: we need the license files to present in %{crate_instdir} because some packages may access them in there (e.g. to show a the README internally in help or something like that). So right now we say something like %files %license %{crate_instdir}/LICENSE %{crate_instdir}/ I thought rpm would be smart enough to understand that all files in that directory should be packaged, except that one should tagged as license. Maybe there's some way to tell rpm that. (But yeah, that's something to fix in rust2rpm.) > - 's/Patch0:/Patch: /'. Source isn't numbered and Patch doesn't need to be > either. Numbering Sources and Patches is done automatically in modern RPM > versions. That's an RFE for rust2rpm too. Oh, I see you submitted a PR already. I'll take a look. > rpmlint finds: > rust-print_bytes.src: W: strange-permission rust-print_bytes.spec 600 > NOTE: This should be fixed Meh, this is actually an obsolete check. git doesn't maintain a full permission mask, but only three bits essentially: directory?, writable?, executable?. Git simply doesn't store information about permission mask for other or group users, but just uses some fixed values (determined by umask, core.sharedRepository). And of course dist-git is git. So even if we have a file with such permissions, once it's imported into dist-git, it'll get the usual mask anyway. So the whole check and the warning are just pointless. > rust-print_bytes+default-devel.noarch: W: no-documentation > rust-print_bytes+specialization-devel.noarch: W: no-documentation > NOTE: spurious > > rust-print_bytes+default-devel.noarch: W: invalid-license Apache-2.0 > rust-print_bytes+specialization-devel.noarch: W: invalid-license Apache-2.0 > rust-print_bytes.src: W: invalid-license Apache-2.0 > rust-print_bytes-devel.noarch: W: invalid-license Apache-2.0 > NOTE: I assume you switched these to use SPDX identifiers now that that's > been > approved. The Change owners said[1] that's allowed now, but apparently > rpmlint > hasn't been updated. Yeah. There's a PR for rust2rpm with this. > [x]: Patches link to upstream bugs/comments/lists or are otherwise > justified. > NOTE: rust2rpm -p should probably give a more descriptive comment > than "# Initial patched metadata", but oh well. Ack. It should at least say if it was generated automatically or by the maintainer. -- Thanks!
(In reply to Zbigniew Jędrzejewski-Szmek from comment #3) > (In reply to Maxwell G from comment #1) > > - Package does not contain duplicates in %files. > > Note: warning: File listed twice: > > /usr/share/cargo/registry/print_bytes-0.6.0/COPYRIGHT > > See: https://docs.fedoraproject.org/en-US/packaging- > > guidelines/#_duplicate_files > > > > This is a problem with rust2rpm and not necessarily something that can be > > fixed here. > > > > I suppose the best way to handle this for now would be to remove the license > > files and README from %{crate_instdir} in %install and just mark the relative > > paths with `%doc` and `%license` to install them in the usual locations. > > This way of doing this was added on request: we need the license files to > present > in %{crate_instdir} because some packages may access them in there (e.g. to > show a > the README internally in help or something like that). So right now we say > something > like > > %files > %license %{crate_instdir}/LICENSE > %{crate_instdir}/ > > I thought rpm would be smart enough to understand that all files in that > directory > should be packaged, except that one should tagged as license. Maybe there's > some > way to tell rpm that. > > (But yeah, that's something to fix in rust2rpm.) $ rpm -qdp results/rust-print_bytes-devel-0.6.0-1.fc37.noarch.rpm /usr/share/cargo/registry/print_bytes-0.6.0/README.md $ rpm -qLp results/rust-print_bytes-devel-0.6.0-1.fc37.noarch.rpm /usr/share/cargo/registry/print_bytes-0.6.0/COPYRIGHT /usr/share/cargo/registry/print_bytes-0.6.0/LICENSE-APACHE /usr/share/cargo/registry/print_bytes-0.6.0/LICENSE-MIT It still works, but I think it's still worth fixing. See https://bugzilla.redhat.com/show_bug.cgi?id=2103367#c5. > > [x]: Patches link to upstream bugs/comments/lists or are otherwise > > justified. > > NOTE: rust2rpm -p should probably give a more descriptive comment > > than "# Initial patched metadata", but oh well. > > Ack. It should at least say if it was generated automatically or by the > maintainer. > Yeah, and it should also clarify that this is a downstream only patch that's not applicable upstream. > > Thanks! Sure, no problem!