Bug 2105993
Summary: | Review Request: perl-Data-Constraint - Prototypical value checking | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ralf Corsepius <rc040203> |
Component: | Package Review | Assignee: | Jitka Plesnikova <jplesnik> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | jplesnik, package-review |
Target Milestone: | --- | Flags: | jplesnik:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2022-09-09 12:15:06 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Ralf Corsepius
2022-07-11 13:12:41 UTC
Source file is ok Summary is ok License FIX: We have new licensing guidelines. Please write a license tag value in SPDX syntax $ license-fedora2spdx "Artistic 2.0" Artistic-2.0 Description is ok URL and Source0 are ok All tests passed BuildRequires FIX: Please add build-requires: coreutils - needed for macro %{_fixperms} TODO: Please increase version restriction for perl(ExtUtils::MakeMaker) >= 6.76 NO_PACKLIST is provided since this version. $ rpm -qp --requires perl-Data-Constraint-1.203-1.fc38.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(base) 1 perl(Class::Prototyped) 1 perl(:MODULE_COMPAT_5.36.0) 1 perl(strict) 1 perl(:VERSION) >= 5.8.0 1 perl(warnings) Binary requires are Ok. $ rpm -qp --provides perl-Data-Constraint-1.203-1.fc38.noarch.rpm | sort | uniq -c 1 perl(Data::Constraint) = 1.203 1 perl-Data-Constraint = 1.203-1.fc38 Binary provides are Ok. $ rpmlint ./perl-Data-Constraint* =========================== rpmlint session starts =========================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s Rpmlint is ok FIX: Please remove duplicity of 'INSTALLDIRS=vendor' on line 46. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' item and provide a new spec file. Resolution: Not Approved (In reply to Jitka Plesnikova from comment #1) > License > FIX: We have new licensing guidelines. Please write a license tag value in > SPDX syntax > $ license-fedora2spdx "Artistic 2.0" > Artistic-2.0 Done, though I generally disagree with most of the new guidelines. > TODO: Please increase version restriction for perl(ExtUtils::MakeMaker) >= > 6.76 > NO_PACKLIST is provided since this version. No active Fedora release is using such an old version. => I added this, but I do not see any sense in enforcing it. > FIX: Please remove duplicity of 'INSTALLDIRS=vendor' on line 46. Done. Update: Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Data-Constraint.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Data-Constraint-1.203-2.fc38.src.rpm > License > FIX: We have new licensing guidelines. Please write a license tag value in > SPDX syntax > $ license-fedora2spdx "Artistic 2.0" > Artistic-2.0 -License: Artistic 2.0 +License: Artistic-2.0 Done > BuildRequires > FIX: Please add build-requires: > coreutils - needed for macro %{_fixperms} +BuildRequires: coreutils Done > TODO: Please increase version restriction for perl(ExtUtils::MakeMaker) >= 6.76 > NO_PACKLIST is provided since this version. -BuildRequires: perl(ExtUtils::MakeMaker) >= 6.64 +BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 Done > FIX: Please remove duplicity of 'INSTALLDIRS=vendor' on line 46. -%{__perl} Makefile.PL INSTALLDIRS=vendor INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1 +%{__perl} Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1 Done The package is in line with Fedora and Perl packaging guide lines. Resolution: Approved (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Data-Constraint |