Bug 2105993 - Review Request: perl-Data-Constraint - Prototypical value checking
Summary: Review Request: perl-Data-Constraint - Prototypical value checking
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-07-11 13:12 UTC by Ralf Corsepius
Modified: 2022-09-09 12:15 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-09-09 12:15:06 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Ralf Corsepius 2022-07-11 13:12:41 UTC
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Data-Constraint.spec
SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Data-Constraint-1.203-1.fc37.src.rpm
Description: 
A constraint is some sort of condition on a datum. This module checks one
condition against one value at a time, and I call the thing that checks
that condition the "constraint". A constraint returns true or false, and
that's it. It should have no side effects, it should not change program
flow, and it should mind its own business. Let the thing that calls the
constraint figure out what to do with it. I want something that says "yes"
or "no" (and I discuss why this needs a fancy module later).

Fedora Account System Username: corsepiu


This package is yet another, so far missing, optional dependency of 
perl-Type-Tiny.

Comment 1 Jitka Plesnikova 2022-08-18 15:09:37 UTC
Source file is ok
Summary is ok

License
FIX: We have new licensing guidelines. Please write a license tag value in SPDX syntax
    $ license-fedora2spdx "Artistic 2.0"
    Artistic-2.0

Description is ok
URL and Source0 are ok
All tests passed

BuildRequires
FIX: Please add build-requires:
     coreutils - needed for macro %{_fixperms}
TODO: Please increase version restriction for perl(ExtUtils::MakeMaker) >= 6.76
      NO_PACKLIST is provided since this version.

$ rpm -qp --requires perl-Data-Constraint-1.203-1.fc38.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(base)
      1 perl(Class::Prototyped)
      1 perl(:MODULE_COMPAT_5.36.0)
      1 perl(strict)
      1 perl(:VERSION) >= 5.8.0
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Data-Constraint-1.203-1.fc38.noarch.rpm | sort | uniq -c
      1 perl(Data::Constraint) = 1.203
      1 perl-Data-Constraint = 1.203-1.fc38
Binary provides are Ok.

$ rpmlint ./perl-Data-Constraint*
=========================== rpmlint session starts ===========================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s
Rpmlint is ok

FIX: Please remove duplicity of 'INSTALLDIRS=vendor' on line 46.

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items, consider fixing 'TODO' item and provide a new spec file.

Resolution:
Not Approved

Comment 2 Ralf Corsepius 2022-08-20 15:31:05 UTC
(In reply to Jitka Plesnikova from comment #1)

> License
> FIX: We have new licensing guidelines. Please write a license tag value in
> SPDX syntax
>     $ license-fedora2spdx "Artistic 2.0"
>     Artistic-2.0
Done, though I generally disagree with most of the new guidelines.

> TODO: Please increase version restriction for perl(ExtUtils::MakeMaker) >=
> 6.76
>       NO_PACKLIST is provided since this version.
No active Fedora release is using such an old version.
=> I added this, but I do not see any sense in enforcing it.

> FIX: Please remove duplicity of 'INSTALLDIRS=vendor' on line 46.
Done. 

Update:
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Data-Constraint.spec
SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Data-Constraint-1.203-2.fc38.src.rpm

Comment 3 Jitka Plesnikova 2022-08-22 07:01:14 UTC
> License
> FIX: We have new licensing guidelines. Please write a license tag value in
> SPDX syntax
>     $ license-fedora2spdx "Artistic 2.0"
>     Artistic-2.0
-License:        Artistic 2.0
+License:        Artistic-2.0
Done
> BuildRequires
> FIX: Please add build-requires:
>      coreutils - needed for macro %{_fixperms}
+BuildRequires:  coreutils
Done

> TODO: Please increase version restriction for perl(ExtUtils::MakeMaker) >= 6.76
>       NO_PACKLIST is provided since this version.
-BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.64
+BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.76
Done

> FIX: Please remove duplicity of 'INSTALLDIRS=vendor' on line 46.
-%{__perl} Makefile.PL INSTALLDIRS=vendor INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1
+%{__perl} Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1
Done

The package is in line with Fedora and Perl packaging guide lines.

Resolution:
Approved

Comment 4 Gwyn Ciesla 2022-08-22 13:29:58 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Data-Constraint


Note You need to log in before you can comment on or make changes to this bug.