Bug 210705
| Summary: | kickstart.py throws exception in wrong BIOS disk condition (weekly build 10/12/06) | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Rezwanul Kabir <rezwanul_kabir> |
| Component: | anaconda | Assignee: | Chris Lumens <clumens> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | high | Docs Contact: | |
| Priority: | medium | ||
| Version: | 5.0 | CC: | wwlinuxengineering |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 11.1.2.5-1 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-11-03 14:53:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 200812 | ||
This bug is blocking Dell's internal test efforts. Can we get the fix at least in the next weekly build and preferably a test rpm even before that to verify that the issue has been fixed? --onbiosdisk takes a number corresponding to a BIOS disk like 80, 82, etc. Perhaps pykickstart should be modified to detect this. Why is it NOTABUG? Because you're giving --onbiosdisk the wrong information (the string "sda" apparently, instead of an integer), and it is rightly displaying an error message to tell you so. I will modify the error checking for --onbiosdisk to expect an integer instead of a string, however, to make it more clear what the problem is. Not sure where you got the info about the content of the ks.cfg. But below
is what ks.cfg contained...
part /boot --fstype ext3 --size=100 --onbiosdisk=80 --asprimary
part pv.23225 --size=0 --grow --onbiosdisk=80
Note, onbiosdisk has 80.
The issue here is below,
pd.disk = isys.doGetBiosDisk(pd.onbiosdisk)
if pd.disk != "":
pd.disk here should contain string such as "sda" and you are raising
exception when you have a non NULL string...
I was getting the info about ks.cfg from the error message you pasted into the bug report, since I didn't see any piece from your kickstart config posted. I was trusting the error message to be correct, but now that I see what you're doing I know that's not the case. I'll commit this for the next build of anaconda. Thanks. Is this fix confirmed for beta2? Yes, it looks like the fix made it into the beta 2 tree. Fix verified. Please close. Thanks! |
Description of problem: anaconda throws exception when it actually COULD find a BIOS disk. The method "doPartition" in kickstart.py contains the followings: def doPartition(self, id, args): KickstartHandlers.doPartition(self, args) pd = self.ksdata.partitions[-1] uniqueID = None if pd.onbiosdisk != "": pd.disk = isys.doGetBiosDisk(pd.onbiosdisk) if pd.disk != "": raise KickstartValueError, formatErrorMsg(self.lineno, msg="Specified BIOS disk %s cannot be determined" % pd.disk) Version-Release number of selected component (if applicable): anaconda-11.1.0.108-1 ( weekly build 10/12/06 ) How reproducible: Always with BIOS disk option in ks.cfg. Steps to Reproduce: 1.Use ks.cfg with BIOS disk option 2. 3. Actual results: The following error messages are printed: (F6) Error Parsing Kickstart Config The following error was found while parsing your kickstart configuration: The following problem occurred on line 35 of the kickstart file: Specified BIOS disk sda cannot be determined (Button)Reboot Expected results: Install should go on without any error Additional info: