Bug 2109021

Summary:	virt-v2v: Import dialog, attaching VirtIO drivers failed with Invalid ISO image path error.
Product:	[oVirt] ovirt-engine	Reporter:	Nisim Simsolo <nsimsolo>
Component:	BLL.Virt	Assignee:	Milan Zamazal <mzamazal>
Status:	CLOSED DUPLICATE	QA Contact:	meital avital <mavital>
Severity:	medium	Docs Contact:
Priority:	low
Version:	4.5.2	CC:	bugs, michal.skrivanek, mzamazal, nsimsolo, smelamud
Target Milestone:	ovirt-4.5.3	Flags:	pm-rhel: ovirt-4.5?
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-08-09 07:31:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nisim Simsolo 2022-07-20 09:33:09 UTC

Description of problem:
Trying to import VMware Windows VM with virtio-win drivers from data domain cannot be executed because the ISO image path cannot be find.
from engine.log: 
2022-07-20 12:25:41,944+03 WARN  [org.ovirt.engine.core.bll.exportimport.ImportVmFromExternalProviderCommand] (default task-23) [] Validation of action 'ImportVmFromExternalProvider' failed for user admin@internal-authz. Reasons: VAR__ACTION__IMPORT,VAR__TYPE__VM,ERROR_CANNOT_FIND_ISO_IMAGE_PATH

Version-Release number of selected component (if applicable):
ovirt-engine-4.5.1.3-0.36.el8ev
vdsm-4.50.2.1-1.el8ev.x86_64
libvirt-8.0.0-5.2.module+el8.6.0+15256+3a0914fe.x86_64
qemu-kvm-6.2.0-11.module+el8.6.0+15668+464a1f31.2.x86_64
virt-v2v-1.42.0-19.module+el8.6.0+15577+2ffd6ffa.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Remove ISO domain and add virtio-win.iso to data domain.
2. Open import dialog and add virtio-win drivers. 
3. click OK to continue. 

Actual results:
action failed with pop up message:
Error while executing action:
esx7.0-win2016-x86_64-time_yy-mm-dd:
Invalid ISO image path

Expected results:
It should be possible to use virtio-win.iso from data domain.

Additional info:
screenshot attached, vdsm.log and engine.log (2022-07-20 12:30:00,804+03) attached.

Comment 4 Milan Zamazal 2022-07-20 10:15:23 UTC

The validation apparently fails in ImportVmFromExternalProviderCommand.java:

 if (getVm().getOrigin() != OriginType.KVM &&
         getParameters().getVirtioIsoName() != null &&
         getActiveIsoDomainId() == null) {
     return failValidation(EngineMessage.ERROR_CANNOT_FIND_ISO_IMAGE_PATH);
 }

Nisim, is it a regression or not? What's the difference to Bug 1632068? That we import a non-kvm VM this time? Is it supposed to work this way?

Comment 5 Nisim Simsolo 2022-07-20 11:02:41 UTC

First, just to clarify: 
1. when using ISO domain it's possible to attach VirtIO drivers and import VM from VMware or Xen.
2. As for the virtio-win.iso in data domain, same issue occurs when trying to import from Xen.

> Nisim, is it a regression or not? 
Yes, it worked before.

<What's the difference to Bug 1632068? That we import a non-kvm VM this time? Is it supposed to work this way?
The option to attach VirtIO drivers when importing from KVM is no longer optional (checkbox and dropbox removed)
The WARN log from bug 1632068 is the same as this one, but I can't tell if it's the same issue or not.

Comment 6 Michal Skrivanek 2022-07-21 07:09:50 UTC

using iso domain is a reasonable workaround

Comment 7 Milan Zamazal 2022-07-22 18:07:35 UTC

I'll look whether the fix is possibly trivial, otherwise we'll close the bug.

Comment 8 Shmuel Melamud 2022-08-08 23:30:23 UTC

Is this bug different from bug 1721455?

Comment 9 Milan Zamazal 2022-08-09 07:31:03 UTC

As pointed out on GitHub, this bug is indeed the same as Bug 1721455, so closing it as a duplicate.

*** This bug has been marked as a duplicate of bug 1721455 ***