Description of problem: Trying to import VMware Windows VM with virtio-win drivers from data domain cannot be executed because the ISO image path cannot be find. from engine.log: 2022-07-20 12:25:41,944+03 WARN [org.ovirt.engine.core.bll.exportimport.ImportVmFromExternalProviderCommand] (default task-23) [] Validation of action 'ImportVmFromExternalProvider' failed for user admin@internal-authz. Reasons: VAR__ACTION__IMPORT,VAR__TYPE__VM,ERROR_CANNOT_FIND_ISO_IMAGE_PATH Version-Release number of selected component (if applicable): ovirt-engine-4.5.1.3-0.36.el8ev vdsm-4.50.2.1-1.el8ev.x86_64 libvirt-8.0.0-5.2.module+el8.6.0+15256+3a0914fe.x86_64 qemu-kvm-6.2.0-11.module+el8.6.0+15668+464a1f31.2.x86_64 virt-v2v-1.42.0-19.module+el8.6.0+15577+2ffd6ffa.x86_64 How reproducible: 100% Steps to Reproduce: 1. Remove ISO domain and add virtio-win.iso to data domain. 2. Open import dialog and add virtio-win drivers. 3. click OK to continue. Actual results: action failed with pop up message: Error while executing action: esx7.0-win2016-x86_64-time_yy-mm-dd: Invalid ISO image path Expected results: It should be possible to use virtio-win.iso from data domain. Additional info: screenshot attached, vdsm.log and engine.log (2022-07-20 12:30:00,804+03) attached.
The validation apparently fails in ImportVmFromExternalProviderCommand.java: if (getVm().getOrigin() != OriginType.KVM && getParameters().getVirtioIsoName() != null && getActiveIsoDomainId() == null) { return failValidation(EngineMessage.ERROR_CANNOT_FIND_ISO_IMAGE_PATH); } Nisim, is it a regression or not? What's the difference to Bug 1632068? That we import a non-kvm VM this time? Is it supposed to work this way?
First, just to clarify: 1. when using ISO domain it's possible to attach VirtIO drivers and import VM from VMware or Xen. 2. As for the virtio-win.iso in data domain, same issue occurs when trying to import from Xen. > Nisim, is it a regression or not? Yes, it worked before. <What's the difference to Bug 1632068? That we import a non-kvm VM this time? Is it supposed to work this way? The option to attach VirtIO drivers when importing from KVM is no longer optional (checkbox and dropbox removed) The WARN log from bug 1632068 is the same as this one, but I can't tell if it's the same issue or not.
using iso domain is a reasonable workaround
I'll look whether the fix is possibly trivial, otherwise we'll close the bug.
Is this bug different from bug 1721455?
As pointed out on GitHub, this bug is indeed the same as Bug 1721455, so closing it as a duplicate. *** This bug has been marked as a duplicate of bug 1721455 ***