Bug 2112636
| Summary: | Review Request: pt-astra-serif-fonts - Font that is metric compatible with Times New Roman | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Benson Muite <benson_muite> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Parag AN(पराग) <panemade> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | admiller, leamas.alec, michel, ngompa13, package-review, panemade, pingou |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-09-16 16:11:10 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Benson Muite
2022-07-31 07:58:34 UTC
Alternative download location https://www.paratype.com/fonts/pt/pt-astra-serif?tab=packages @ngompa13 Entered the wrong component which automatically assigned you as a reviewer, unassigning did not occur when changing the component. Feel free to remove yourself. I like to review this package. I suggest below Version: 1.002 %global foundry PT %global fontlicense OFL-1.1 %global fontfamily PT Astra Serif Fix the changelog for version 1.002 Similar changes are suggested for https://bugzilla.redhat.com/show_bug.cgi?id=2112639 Thanks for the suggestions. spec: https://download.copr.fedorainfracloud.org/results/fed500/PTAstra-serif/fedora-36-x86_64/04709031-pt-astra-serif-fonts/PTAstraSerif.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/PTAstra-serif/fedora-36-x86_64/04709031-pt-astra-serif-fonts/pt-astra-serif-fonts-1.002-1.fc36.src.rpm Updated spec and srpm spec: https://download.copr.fedorainfracloud.org/results/fed500/PTAstra-serif/fedora-36-x86_64/04741712-pt-astra-serif-fonts/pt-astra-serif-fonts.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/PTAstra-serif/fedora-36-x86_64/04741712-pt-astra-serif-fonts/pt-astra-serif-fonts-1.002-3.fc36.src.rpm Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/test/2112636-pt- astra-serif-fonts/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ Source checksums ---------------- https://astralinux.ru/information/fonts-astra/font-ptastra-serif-ver1002.zip : CHECKSUM(SHA256) this package : db8328ae5b56c6d783d80da1c7dba1355c2230f3be3874b60a2cf199b98cd29a CHECKSUM(SHA256) upstream package : 7922cc0bedd3308be652b33c528f2d2152ec6503375764eb2cfecc989a476799 diff -r also reports differences The upstream URL is now https://astralinux.ru/information/fonts-astra/font-ptastra-serif-ver1003.zip Update the spec file and submit new package here. Thanks. Updated. spec: https://download.copr.fedorainfracloud.org/results/fed500/PTAstra-serif/fedora-36-x86_64/04750006-pt-astra-serif-fonts/pt-astra-serif-fonts.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/PTAstra-serif/fedora-36-x86_64/04750006-pt-astra-serif-fonts/pt-astra-serif-fonts-1.003-1.fc36.src.rpm Thank you for the updates.
Sorry I missed to check fontconfig file and now realized that family name written is not correct.
See $ fc-query -f '%{family}\n' PTAstraSerif-Regular.ttf
PT Astra Serif
So correct this in 60-pt-astra-serif-fonts.xml by replacing "PT Astra" with "PT Astra Serif"
Rest looks okay to me so APPROVING this package :)
Many thanks for your guidance. Updated: spec: https://download.copr.fedorainfracloud.org/results/fed500/PTAstra-serif/fedora-36-x86_64/04751244-pt-astra-serif-fonts/pt-astra-serif-fonts.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/PTAstra-serif/fedora-36-x86_64/04751244-pt-astra-serif-fonts/pt-astra-serif-fonts-1.003-1.fc36.src.rpm (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/pt-astra-serif-font (In reply to Gwyn Ciesla from comment #11) > (fedscm-admin): The Pagure repository was created at > https://src.fedoraproject.org/rpms/pt-astra-serif-font Thanks for this. Is it possible to change the name, missed an s, or should the repository be deleted and created again? (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/pt-astra-serif-fonts |