Bug 2112636 - Review Request: pt-astra-serif-fonts - Font that is metric compatible with Times New Roman
Summary: Review Request: pt-astra-serif-fonts - Font that is metric compatible with Ti...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Parag AN(पराग)
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-07-31 07:58 UTC by Benson Muite
Modified: 2022-09-16 16:11 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-09-16 16:11:10 UTC
Type: Bug
Embargoed:
panemade: fedora-review+


Attachments (Terms of Use)

Comment 1 Benson Muite 2022-07-31 08:33:01 UTC
Alternative download location https://www.paratype.com/fonts/pt/pt-astra-serif?tab=packages

Comment 2 Benson Muite 2022-08-01 05:41:15 UTC
@ngompa13 Entered the wrong component which automatically assigned you as a reviewer, unassigning did not occur when changing the component. Feel free to remove yourself.

Comment 3 Parag AN(पराग) 2022-08-02 10:31:53 UTC
I like to review this package.

Comment 4 Parag AN(पराग) 2022-08-02 11:17:17 UTC
I suggest below

Version: 1.002
%global foundry           PT
%global fontlicense  OFL-1.1
%global fontfamily        PT Astra Serif

Fix the changelog for version 1.002

Similar changes are suggested for https://bugzilla.redhat.com/show_bug.cgi?id=2112639

Comment 7 Parag AN(पराग) 2022-08-18 14:10:23 UTC
Issues:
=======
- Sources used to build the package match the upstream source, as provided
  in the spec URL.
  Note: Upstream MD5sum check error, diff is in /home/test/2112636-pt-
  astra-serif-fonts/diff.txt
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

Source checksums
----------------
https://astralinux.ru/information/fonts-astra/font-ptastra-serif-ver1002.zip :
  CHECKSUM(SHA256) this package     : db8328ae5b56c6d783d80da1c7dba1355c2230f3be3874b60a2cf199b98cd29a
  CHECKSUM(SHA256) upstream package : 7922cc0bedd3308be652b33c528f2d2152ec6503375764eb2cfecc989a476799
diff -r also reports differences

The upstream URL is now https://astralinux.ru/information/fonts-astra/font-ptastra-serif-ver1003.zip
Update the spec file and submit new package here.

Comment 9 Parag AN(पराग) 2022-08-20 06:49:04 UTC
Thank you for the updates.
Sorry I missed to check fontconfig file and now realized that family name written is not correct.

See $ fc-query -f '%{family}\n' PTAstraSerif-Regular.ttf 
PT Astra Serif

So correct this in 60-pt-astra-serif-fonts.xml by replacing "PT Astra" with "PT Astra Serif"

Rest looks okay to me so APPROVING this package :)

Comment 11 Gwyn Ciesla 2022-08-22 18:26:52 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/pt-astra-serif-font

Comment 12 Benson Muite 2022-08-25 07:56:04 UTC
(In reply to Gwyn Ciesla from comment #11)
> (fedscm-admin):  The Pagure repository was created at
> https://src.fedoraproject.org/rpms/pt-astra-serif-font

Thanks for this. Is it possible to change the name, missed an s, or should the repository be deleted and created again?

Comment 13 Gwyn Ciesla 2022-08-25 14:13:02 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/pt-astra-serif-fonts


Note You need to log in before you can comment on or make changes to this bug.