Bug 2113689

Summary: rubygem-asciidoctor-pdf: FTBFS in Fedora rawhide/f37
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: rubygem-asciidoctor-pdfAssignee: Sergi <tripledes>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 37CC: adrian.bradshaw, chris.brown, egolov, fedora, me, vondruch
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rubygem-asciidoctor-pdf-1.6.2-4.fc38 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-01-16 07:25:13 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2045102, 2117176    
Attachments:
Description Flags
build.log
none
root.log
none
state.log none

Description Fedora Release Engineering 2022-08-02 00:13:00 UTC 
rubygem-asciidoctor-pdf failed to build from source in Fedora rawhide/f37

https://koji.fedoraproject.org/koji/taskinfo?taskID=89897614


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild
Please fix rubygem-asciidoctor-pdf at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
rubygem-asciidoctor-pdf will be orphaned. Before branching of Fedora 38,
rubygem-asciidoctor-pdf will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
Comment 1 Fedora Release Engineering 2022-08-02 00:13:02 UTC 
Created attachment 1902486 [details]
build.log
Comment 2 Fedora Release Engineering 2022-08-02 00:13:04 UTC 
Created attachment 1902487 [details]
root.log

file root.log too big, will only attach last 32768 bytes
Comment 3 Fedora Release Engineering 2022-08-02 00:13:06 UTC 
Created attachment 1902488 [details]
state.log
Comment 4 Ben Cotton 2022-08-09 13:33:27 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora Linux 37 development cycle.
Changing version to 37.
Comment 5 Vít Ondruch 2022-09-08 12:06:13 UTC 
I think this FTBFS could be fixed by the following patch:

https://github.com/asciidoctor/asciidoctor-pdf/commit/0fc983c86cdf49f0ce46618aab67e765e32ee0db

The specific issue seems to be caused by error_highlight gem newly introduced in Ruby 3.1.
Comment 6 Sergi 2022-09-08 20:42:31 UTC 
@vondruch do you think the patch for the converter.rb is the key? I had a look to the commit and not clear how that would fix it, going to give it a try but to be honest I think we should probably push this package at least to 2.0.0.
Comment 7 Vít Ondruch 2022-09-09 09:48:46 UTC 
(In reply to Sergi from comment #6)
> @vondruch do you think the patch for the converter.rb is the key?
> I had a look to the commit and not clear how that would fix it, going to
> give it a try but to be honest

Yes, it is.

I had long discussion about it with upstream here [1], but I don't think it is worth of reading ;)

> I think we should probably push this package
> at least to 2.0.0.

This should also help, yes. Probably easier way.


[1]: https://github.com/asciidoctor/asciidoctor-pdf/issues/2336
Comment 8 Sergi 2022-09-09 21:46:47 UTC 
Seems the patch worked for rawhide [0], will try tomorrow to get a build for f37 and report back.
Comment 9 Sergi 2022-09-09 21:47:24 UTC 
(In reply to Sergi from comment #8)
> Seems the patch worked for rawhide [0], will try tomorrow to get a build for
> f37 and report back.

[0] https://koji.fedoraproject.org/koji/taskinfo?taskID=91844275
Comment 10 Fedora Update System 2022-09-10 22:04:12 UTC 
FEDORA-2022-d07717bac8 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d07717bac8
Comment 11 Fedora Update System 2022-09-11 20:11:08 UTC 
FEDORA-2022-d07717bac8 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-d07717bac8`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d07717bac8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 12 Vít Ondruch 2022-09-12 08:51:22 UTC 
(In reply to Sergi from comment #8)
> Seems the patch worked for rawhide [0], will try tomorrow to get a build for
> f37 and report back.

Great!

BTW you have missed Rawhide / F38 build which ideally should have been out first.
Comment 13 Sergi 2022-09-12 20:55:41 UTC 
(In reply to Vít Ondruch from comment #12)
> (In reply to Sergi from comment #8)
> > Seems the patch worked for rawhide [0], will try tomorrow to get a build for
> > f37 and report back.
> 
> Great!
> 
> BTW you have missed Rawhide / F38 build which ideally should have been out
> first.

Thanks for the catch.

https://bodhi.fedoraproject.org/updates/FEDORA-2022-8e7040d654
Comment 14 Vít Ondruch 2022-09-13 08:10:04 UTC 
Thx a lot 👍
Comment 15 Fedora Update System 2022-09-26 00:16:20 UTC 
FEDORA-2022-d07717bac8 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.