Bug 2113996

Summary: Search for non-integer job id will result in error page
Product: Red Hat Satellite Reporter: Peter Dragun <pdragun>
Component: Remote ExecutionAssignee: Adam Ruzicka <aruzicka>
Status: CLOSED ERRATA QA Contact: Peter Ondrejka <pondrejk>
Severity: low Docs Contact:
Priority: unspecified    
Version: 6.12.0CC: aruzicka, zhunting
Target Milestone: 6.12.0Keywords: EasyFix, Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rubygem-foreman_remote_execution-7.2.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-11-16 13:35:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screenshot none

Description Peter Dragun 2022-08-02 14:02:14 UTC
Created attachment 1902872 [details]
screenshot

Description of problem:
Searching for non-integer ID in jobs results in an error page. This should be handled better and show just a warning in the search bar, or something.

Version-Release number of selected component (if applicable):
6.12

How reproducible:
always

Steps to Reproduce:
1. Navigate to Monitor -> Jobs
2. Search for e.g. `id = foo`

Actual results:
SQL error is shown.

Expected results:
There should be some warning about not supported id, as for example in Hosts 

Additional info:

Comment 3 Bryan Kearney 2022-08-03 12:05:14 UTC
Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/35327 has been resolved.

Comment 4 Peter Ondrejka 2022-08-11 13:26:53 UTC
Checked on Satellite 6.12 snap 6, searching by id is now validated, but the same problem applies to targeted_host_id that remains untreated: 

Searching by targeted_host_id = "foo" results in an error page with: 
PG::InvalidTextRepresentation: ERROR: invalid input syntax for type integer: "foo" LINE 1: ...st_id" AND "hosts"."type" = $3 WHERE ((hosts.id = 'foo')) OR... ^

Comment 6 Peter Ondrejka 2022-09-08 17:45:47 UTC
Verified on Sat 6.12 snap 10

Comment 10 errata-xmlrpc 2022-11-16 13:35:05 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.12 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:8506