Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2113996 - Search for non-integer job id will result in error page
Summary: Search for non-integer job id will result in error page
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Remote Execution
Version: 6.12.0
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: 6.12.0
Assignee: Adam Ruzicka
QA Contact: Peter Ondrejka
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-08-02 14:02 UTC by Peter Dragun
Modified: 2022-11-16 13:35 UTC (History)
2 users (show)

Fixed In Version: rubygem-foreman_remote_execution-7.2.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-11-16 13:35:05 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screenshot (40.09 KB, image/png)
2022-08-02 14:02 UTC, Peter Dragun
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 35327 0 Normal New Search on job invocation id is missing input validation 2022-08-03 10:35:48 UTC
Red Hat Issue Tracker SAT-11966 0 None None None 2022-09-05 08:42:53 UTC
Red Hat Issue Tracker SAT-12347 0 None None None 2022-09-05 08:42:52 UTC
Red Hat Issue Tracker SAT-12348 0 None None None 2022-11-11 07:03:13 UTC
Red Hat Issue Tracker SAT-12349 0 None None None 2022-11-11 07:03:16 UTC
Red Hat Product Errata RHSA-2022:8506 0 None None None 2022-11-16 13:35:13 UTC

Description Peter Dragun 2022-08-02 14:02:14 UTC
Created attachment 1902872 [details]
screenshot

Description of problem:
Searching for non-integer ID in jobs results in an error page. This should be handled better and show just a warning in the search bar, or something.

Version-Release number of selected component (if applicable):
6.12

How reproducible:
always

Steps to Reproduce:
1. Navigate to Monitor -> Jobs
2. Search for e.g. `id = foo`

Actual results:
SQL error is shown.

Expected results:
There should be some warning about not supported id, as for example in Hosts 

Additional info:

Comment 3 Bryan Kearney 2022-08-03 12:05:14 UTC
Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/35327 has been resolved.

Comment 4 Peter Ondrejka 2022-08-11 13:26:53 UTC
Checked on Satellite 6.12 snap 6, searching by id is now validated, but the same problem applies to targeted_host_id that remains untreated: 

Searching by targeted_host_id = "foo" results in an error page with: 
PG::InvalidTextRepresentation: ERROR: invalid input syntax for type integer: "foo" LINE 1: ...st_id" AND "hosts"."type" = $3 WHERE ((hosts.id = 'foo')) OR... ^

Comment 6 Peter Ondrejka 2022-09-08 17:45:47 UTC
Verified on Sat 6.12 snap 10

Comment 10 errata-xmlrpc 2022-11-16 13:35:05 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.12 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:8506


Note You need to log in before you can comment on or make changes to this bug.