Bug 2116065
| Summary: | Review Request: rust-primal-check - Fast standalone primality testing | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rust-primal-check-0.3.2-1.fc38 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-10-01 02:29:17 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2116083, 2116092 | ||
|
Description
Orion Poplawski
2022-08-06 19:40:11 UTC
c.f. https://bugzilla.redhat.com/show_bug.cgi?id=2116066#c1 Additionally, this: %files %license LICENSE-* will result in the license files getting installed into the buildroot twice (once in %{crate_instdir}, once in %{_licensedir}). Use this instead (which matches what rust2rpm will generate): %files %license %{crate_instdir}/LICENSE-Apache %license %{crate_instdir}/LICENSE-MIT Should be fixed now Spec URL: https://orion.fedorapeople.org/rust-primal-check.spec SRPM URL: https://orion.fedorapeople.org/rust-primal-check-0.3.1-1.fc38.src.rpm Upstream now provides the license files. Spec URL: https://orion.fedorapeople.org/rust-primal-check.spec SRPM URL: https://orion.fedorapeople.org/rust-primal-check-0.3.2-1.fc38.src.rpm Looks good to me! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide ! test suite is run and all unit tests pass (tests disabled to break dependency loop) - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches Two non-blocking comments: 1. Please make sure to regenerate .spec files with rust2rpm for *every* new version. For example, this line is no longer correct: # Upstream license specification: MIT/Apache-2.0 As the upstream crate metadata has updated the license string to use "OR" instead of the deprecated "/" SPDX syntax. If you don't re-run rust2rpm for new versions, it can result in broken packages (for example, if features or optional dependencies change, the generated subpackages for those features / optional dependencies will be outdated, and will have broken dependencies, or will be missing). 2. Make sure you don't "fedpkg import" the SRPM file that you uploaded for this review. It was already munged by rpmautospec. PS: I tend to build SRPM files for review requests with "rpmbuild -bs", which doesn't expand those macros, and creates SRPM files that are safe to be imported with "fedpkg import". Thanks for the pointers, I'll try to remember them. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-primal-check |