Bug 2116092 - Review Request: rust-rustfft - High-performance FFT library written in pure Rust
Summary: Review Request: rust-rustfft - High-performance FFT library written in pure Rust
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2116065 2116087 2116088
Blocks: 2116220
TreeView+ depends on / blocked
 
Reported: 2022-08-06 23:07 UTC by Orion Poplawski
Modified: 2022-11-11 01:54 UTC (History)
3 users (show)

Fixed In Version: rust-rustfft-6.1.0-1.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-11-11 01:54:44 UTC
Type: Bug
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Orion Poplawski 2022-08-06 23:07:20 UTC
Spec URL: https://orion.fedorapeople.org/rust-rustfft.spec
SRPM URL: https://orion.fedorapeople.org/rust-rustfft-6.0.1-1.fc37.src.rpm
Description:
High-performance FFT library written in pure Rust.

Fedora Account System Username: orion

Comment 1 Benson Muite 2022-08-07 10:13:12 UTC
Unoffical review:

When trying to use fedora-review, get the following:

$fedora-review -b 2116092
INFO: Processing bugzilla bug: 2116092
INFO: Getting .spec and .srpm Urls from : 2116092
INFO:   --> SRPM url: https://orion.fedorapeople.org/rust-rustfft-6.0.1-1.fc37.src.rpm
INFO:   --> Spec url: https://orion.fedorapeople.org/rust-rustfft.spec
INFO: Using review directory: /home/FedoraPackaging/rust-rustfft/2116092-rust-rustfft
INFO: Downloading .spec and .srpm files
INFO: Downloading (Source0): https://crates.io/api/v1/crates/rustfft/6.0.1/download#/rustfft-6.0.1.crate
INFO: Running checks and generating report
ERROR: Exception(/home/FedoraPackaging/rust-rustfft/2116092-rust-rustfft/srpm/rust-rustfft-6.0.1-1.fc37.src.rpm) Config(fedora-rawhide-x86_64) 2 minutes 49 seconds
INFO: Results and/or logs in: /home/FedoraPackaging/rust-rustfft/2116092-rust-rustfft/results
ERROR: Command failed: 
INFO: Reading configuration from /etc/mock/site-defaults.cfg
INFO: Reading configuration from /etc/mock/chroot-aliases.cfg
INFO: Reading configuration from /etc/mock/fedora-rawhide-x86_64.cfg
ERROR: 'mock build failed, see logs in /home/FedoraPackaging/rust-rustfft/2116092-rust-rustfft/results'

Checking build.log

INFO: mock.py version 3.1 starting (python version = 3.10.5, NVR = mock-3.1-1.fc36)...
Start(bootstrap): init plugins
INFO: selinux enabled
Finish(bootstrap): init plugins
Start: init plugins
INFO: selinux enabled
Finish: init plugins
INFO: Signal handler active
Start: run
INFO: Start(/home/FedoraPackaging/rust-rustfft/2116092-rust-rustfft/srpm/rust-rustfft-6.0.1-1.fc37.src.rpm)  Config(fedora-rawhide-x86_64)
Start(bootstrap): chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start(bootstrap): cleaning package manager metadata
Finish(bootstrap): cleaning package manager metadata
INFO: enabled HW Info plugin
Mock Version: 3.1
INFO: Mock Version: 3.1
Finish(bootstrap): chroot init
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start: cleaning package manager metadata
Finish: cleaning package manager metadata
INFO: enabled HW Info plugin
Mock Version: 3.1
INFO: Mock Version: 3.1
Finish: chroot init
Start: build phase for rust-rustfft-6.0.1-1.fc37.src.rpm
Start: build setup for rust-rustfft-6.0.1-1.fc37.src.rpm
Finish: build setup for rust-rustfft-6.0.1-1.fc37.src.rpm
Start: Outputting list of installed packages
Finish: Outputting list of installed packages
Start: rpmbuild rust-rustfft-6.0.1-1.fc37.src.rpm
INFO: Going to install missing dynamic buildrequires
Finish: rpmbuild rust-rustfft-6.0.1-1.fc37.src.rpm
Finish: build phase for rust-rustfft-6.0.1-1.fc37.src.rpm
ERROR: Exception(/home/rust-rustfft/2116092-rust-rustfft/srpm/rust-rustfft-6.0.1-1.fc37.src.rpm) Config(fedora-rawhide-x86_64) 2
 minutes 49 seconds
INFO: Results and/or logs in: /home/FedoraPackaging/rust-rustfft/2116092-rust-rustfft/results
ERROR: Command failed: 
 # /usr/bin/systemd-nspawn -q -M 67cded991acb4e159a889a88e1538eaf -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a
--capability=cap_ipc_lock --bind=/tmp
/mock-resolv.k24h8z6a:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash 
--setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir --setenv=HOSTNAME=mock 
--setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007" 
--setenv=PS1=<mock-chroot> \s-\v\$  --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 
--resolv-conf=off /usr/bin/dnf builddep 
--installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 37 --setopt=deltarpm=False --allowerasing 
--disableplugin=local --disableplugin=spacewalk --disableplugin=versionlock --disableplugin=local 
--disableplugin=spacewalk --disableplugin=versionlock 
/var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/SRPMS/rust-rustfft-6.0.1-1.fc37.buildreqs.nosrc.rpm 
--setopt=tsflags=nocontexts
No matches found for the following disable plugin patterns: local, spacewalk, versionlock
fedora                                           10 kB/s |  36 kB     00:03    
Package rust-packaging-22-2.fc37.x86_64 is already installed.
Package rust-packaging-22-2.fc37.x86_64 is already installed.
Error: 
 Problem 1: nothing provides requested (crate(primal-check/default) >= 0.3.1 with crate(primal-check/default) < 0.4.0~)
 Problem 2: nothing provides requested (crate(strength_reduce/default) >= 0.2.3 with crate(strength_reduce/default) < 0.3.0~)
 Problem 3: nothing provides requested (crate(transpose/default) >= 0.2.0 with crate(transpose/default) < 0.3.0~)
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use 
not only best candidate packages)

Comment 2 Fabio Valentini 2022-08-07 10:17:18 UTC
>  Problem 1: nothing provides requested (crate(primal-check/default) >= 0.3.1 with crate(primal-check/default) < 0.4.0~)
>  Problem 2: nothing provides requested (crate(strength_reduce/default) >= 0.2.3 with crate(strength_reduce/default) < 0.3.0~)
>  Problem 3: nothing provides requested (crate(transpose/default) >= 0.2.0 with crate(transpose/default) < 0.3.0~)

This is expected, this bug is still blocked by reviews for other packages.

I'll review these packages later today.

Comment 4 Fabio Valentini 2022-11-09 16:53:21 UTC
I submitted a scratch build, and it succeeded on all architectures:
https://koji.fedoraproject.org/koji/taskinfo?taskID=93979817

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 5 Gwyn Ciesla 2022-11-10 15:46:32 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rustfft

Comment 6 Orion Poplawski 2022-11-11 01:54:44 UTC
Checked in and built.  Thanks all.


Note You need to log in before you can comment on or make changes to this bug.