Bug 2116079

Summary:	Review Request: rust-primal-sieve - High performance prime sieve
Product:	[Fedora] Fedora	Reporter:	Orion Poplawski <orion>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rust-primal-sieve-0.3.5-1.fc38	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-10-20 03:03:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2116078
Bug Blocks:	2116083

Description Orion Poplawski 2022-08-06 21:54:39 UTC

Spec URL: https://orion.fedorapeople.org/rust-primal-sieve.spec
SRPM URL: https://orion.fedorapeople.org/rust-primal-sieve-0.3.2-1.fc37.src.rpm
Description:
High performance prime sieve.

Fedora Account System Username: orion

Comment 1 Orion Poplawski 2022-08-16 01:19:03 UTC

Upstream now provides the license files.

Spec URL: https://orion.fedorapeople.org/rust-primal-sieve.spec
SRPM URL: https://orion.fedorapeople.org/rust-primal-sieve-0.3.3-1.fc38.src.rpm

Comment 2 Fabio Valentini 2022-10-13 10:13:54 UTC

Sorry for the delay in getting back to this review.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
! test suite is run and all unit tests pass (tests disabled for bootstrapping)
! latest version of the crate is packaged (0.3.3 vs 0.3.5)
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

Some things to keep in mind:

1. Please update the package to version 0.3.5 before importing. A quick test build I did locally showed that 0.3.5 buils fine against rawhide.
2. Ensure to import the files into dist-git that have not been expaned by rpmautospec yet.
3. No need to de-bootstrap immediately, that can happen when somebody pushes the next update for the package.

Comment 3 Gwyn Ciesla 2022-10-14 13:17:21 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-primal-sieve

Comment 4 Orion Poplawski 2022-10-20 03:03:38 UTC

Thanks everyone.  Checked in and built.