Bug 2116078 - Review Request: rust-primal-bit - Bit-vector specialised to the prime-number-related needs of `primal`
Summary: Review Request: rust-primal-bit - Bit-vector specialised to the prime-number-...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2116077
Blocks: 2116079 2116081
TreeView+ depends on / blocked
 
Reported: 2022-08-06 21:49 UTC by Orion Poplawski
Modified: 2022-08-30 01:48 UTC (History)
2 users (show)

Fixed In Version: rust-primal-bit-0.3.1-1.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-08-30 01:48:33 UTC
Type: Bug
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Orion Poplawski 2022-08-06 21:49:42 UTC
Spec URL: https://orion.fedorapeople.org/rust-primal-bit.spec
SRPM URL: https://orion.fedorapeople.org/rust-primal-bit-0.3.0-1.fc37.src.rpm
Description:
Bit-vector specialised to the prime-number-related needs of `primal`.

Fedora Account System Username: orion

Comment 1 Orion Poplawski 2022-08-16 01:14:00 UTC
Upstream now provides the license files.

Spec URL: https://orion.fedorapeople.org/rust-primal-bit.spec
SRPM URL: https://orion.fedorapeople.org/rust-primal-bit-0.3.1-1.fc38.src.rpm

Comment 2 Fabio Valentini 2022-08-18 10:25:49 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

Reminder: You will need to re-run rust2rpm for every new version of the crate in the future, and for every Cargo.toml patch that touches optional dependencies or features.

It appears that you didn't do that between version 0.3.0 and 0.3.1, because the line "# Upstream license specification: MIT/Apache-2.0" is no longer generated for version 0.3.1.

Comment 3 Fabio Valentini 2022-08-18 10:26:20 UTC
Another nit-pick: Remove markdown `markup` from the package's Summary and the bug title. RPM doesn't render markdown anywhere, it's just noise.

Comment 4 Jens Petersen 2022-08-28 05:38:31 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-primal-bit

Comment 5 Orion Poplawski 2022-08-30 01:48:33 UTC
Built.  Thanks all.


Note You need to log in before you can comment on or make changes to this bug.