Bug 2116088
| Summary: | Review Request: rust-transpose - Utility for transposing multi-dimensional data | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rust-transpose-0.2.2-1.fc38 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-11-09 15:04:44 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2116087 | ||
| Bug Blocks: | 2063403, 2116092 | ||
|
Description
Orion Poplawski
2022-08-06 22:42:05 UTC
There's some issues with the current version of this package: 1. upstream project does not include license files You should file a PR with upstream to include LICENSE-APACHE and LICENSE-MIT files. Additionally, the link to the MIT license that you used points at an HTML page, not a plaintext version. Please attempt to resolve this with upstream (i.e. "Copyright <YEAR> <COPYRIGHT HOLDER>" placeholder text also needs to be resolved somehow). I suspect the resolution will be similar to the one in the package for strength_reduce, given that it's the same upstream developer ... 2. drop criterion dependency entirely The "criterion" library is only used in benchmark code. It is safe to remove it entirely from Fedora packages, since we neither build nor run benchmark code. Keeping the dependency usually just inflates the dependency tree and package build times by a huuuuuuge amount. Thanks. Similar license pull request submitted upstream. Removed criterion. New files uploaded. Spec URL: https://orion.fedorapeople.org/rust-transpose.spec SRPM URL: https://orion.fedorapeople.org/rust-transpose-0.2.1-1.fc38.src.rpm !! You still need to add the license files as %license in the -devel package's %files list. !! !! Other than that, looks good to me now, thanks. !! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license files are included with %license in %files (standard license texts manually included; submitted PR to upstream) - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches Upstream responded and added the license files. Spec URL: https://orion.fedorapeople.org/rust-transpose.spec SRPM URL: https://orion.fedorapeople.org/rust-transpose-0.2.2-1.fc38.src.rpm (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-transpose Checked in and built. Thanks all. |