Bug 2116119

Summary:	Add support for vdsm to use nmstate for bridge options
Product:	[oVirt] vdsm	Reporter:	Michael Burman <mburman>
Component:	Core	Assignee:	eraviv
Status:	CLOSED WONTFIX	QA Contact:	Michael Burman <mburman>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.50.2.2	CC:	bugs, mburman, mperina
Target Milestone:	ovirt-4.5.3	Flags:	mperina: ovirt-4.5+
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-09-20 09:21:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Network	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2117485, 2117704
Bug Blocks:

Description Michael Burman 2022-08-07 08:52:19 UTC

Description of problem:
Add support for vdsm to use nmstate for bridge options

In BZ 2108974 we have merged a vdsm code to use nmstate for bridge_opts options in RHV. While the code merged we have discovered that some parameters are broken, as nmstate moved(many versions ago) some of them under stp, instead of the common options. Like 'priority' and more. 
This bug will track the full support of vdsm to use nmstate for bridge_opts in RHV.

Version-Release number of selected component (if applicable):
vdsm-4.50.2.2-1.el8ev.x86_64

Comment 1 eraviv 2022-08-07 10:25:35 UTC

stp options reported by nmstate [1] :

      stp:
        enabled: false
        forward-delay: 15
        hello-time: 2
        max-age: 20
        priority: 32768

https://github.com/nmstate/nmstate/blob/nmstate-1.2/libnmstate/schema.py#L282

Comment 2 eraviv 2022-09-20 09:21:23 UTC

In el8 not only nmstate ignores bridge options when STP is disabled but also NetworkManager.
That's because when NM is configured to use /etc/sysconfig/network-scripts/ifcfg files it ignores STP options when STP is disabled.
In el8 ifcfg files are the default for NetworkManager.

Therefore we decide to close this bug as WONTFIX, because changing the default NetworkManager behavior is out of scope for oVirt\RHV at this point in time.