Bug 2117485 - Apply linux bridge STP setting even STP disabled
Summary: Apply linux bridge STP setting even STP disabled
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: nmstate
Version: 8.8
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: rc
: ---
Assignee: Gris Ge
QA Contact: Mingyu Shi
URL:
Whiteboard:
Depends On: 2117482
Blocks: 2116119
TreeView+ depends on / blocked
 
Reported: 2022-08-11 06:48 UTC by Gris Ge
Modified: 2022-11-22 10:38 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 2117482
Environment:
Last Closed: 2022-09-20 08:26:57 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github nmstate nmstate pull 2036 0 None open [nmstate-1.3] nm linux bridge: Apply STP setting even STP disabled 2022-09-14 10:44:32 UTC
Red Hat Issue Tracker RHELPLAN-130906 0 None None None 2022-08-11 07:42:25 UTC

Description Gris Ge 2022-08-11 06:48:30 UTC
+++ This bug was initially created as a clone of Bug #2117482 +++

Description of problem:

Nmstate currently is ignoring STP settings when STP is disabled. We should raise an warning for state like:

```
      stp:
        enabled: false
        forward-delay: 15
        hello-time: 2
        max-age: 20
        priority: 32768
```

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:

Nmstate is silently ignoring STP settings after STP disabled.

Expected results:

An warning message indicate nmstate is ignoring the changes to STP setting when STP disabled.

Additional info:

Comment 2 Gris Ge 2022-09-14 10:16:26 UTC
RHV use case require nmstate to apply the STP setting regardless it is enabled or not. Since kernel allows so and no harm to other user.

Changing the goal of this bug to apply STP settings even disabled.

Comment 3 Gris Ge 2022-09-14 10:39:41 UTC
RHEL 8.6 backport scratch build could be found at https://people.redhat.com/fge/bz_2117485/

Comment 4 Gris Ge 2022-09-14 10:44:32 UTC
Patch sent to upstream: https://github.com/nmstate/nmstate/pull/2036

Comment 5 Gris Ge 2022-09-19 06:33:15 UTC
Even with nmstate allowing setting STP options with disabled STP, NetworkManager `ifcfg-rh` format connection will reject it. The `keyfile` format works well.

Waiting RHV team decision on action plan.

Comment 6 Gris Ge 2022-09-19 06:35:11 UTC
The NetworkManager has explicit check against this use case:


        if (m[i].only_with_stp && !stp) {
            PARSE_WARNING("'%s' invalid when STP is disabled", key);
            return;
        }


Just FYI.

Comment 7 Gris Ge 2022-09-20 08:26:57 UTC
RHV decided not to pursue this use case any more due to limitation in NetworkManager ifcfg.

This use case works well in RHEL 9.1 where NetworkManager is defaulting keyfile storage and nmstate rust is applying STP settings regardless STP status.

Closing as won't fix.


Note You need to log in before you can comment on or make changes to this bug.