Bug 2118180
| Summary: | Review Request: external-editor-revived - Thunderbird extension that allows editing emails in external editors such as Vim | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dusty Mabe <dustymabe> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <zebob.m> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review, zebob.m |
| Target Milestone: | --- | Flags: | zebob.m:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-12-23 01:19:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Dusty Mabe
2022-08-14 19:15:17 UTC
Upstream URL of the project: https://github.com/Frederick888/external-editor-revived - You should use %global here too:
%define thunderbird_app_id \{3550f703-e582-4d05-9a08-453d09bdfdc6\}
%define extensions_dir %{_libdir}/mozilla/extensions/%{thunderbird_app_id}
- don't use macros starting with __, they are for RPM internal use
%{__mkdir_p} $RPM_BUILD_ROOT%{_libdir}/mozilla/native-messaging-hosts
%{__mkdir_p} $RPM_BUILD_ROOT%{extensions_dir}
Thanks! I fixed both of those issues and updated the links. - License ok - Latest version packaged - Builds in mock - No tests available - No rpmlint errors - Conforms to Packaging Guidelines Package approved. Side note: Since this package will contain a statically linked Rust binary, you'll need to update the license tag to take statically linked Rust components into account. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/external-editor-revived Looks like you have not imported the package yet - please do that. :) Yeah. To be honest I haven't had a chance to get back around to it. I think I had things ready to go but then https://bugzilla.redhat.com/show_bug.cgi?id=2118180#c5 happened and I haven't had a chance to figure that out yet. It might be a few weeks. You can use this command in the source directory in a mock chroot after a successful build:
cargo tree --workspace --offline --edges no-build,no-dev,no-proc-macro --no-dedupe --target all --prefix none --format "# {l}" | sed -e "s: / :/:g" -e "s:/: OR :g" | sort -u
This should print a list of all unique licenses that end up getting statically linked into your binary.
FEDORA-2022-d6fde24a93 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d6fde24a93 FEDORA-2022-be776dbf04 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-be776dbf04 FEDORA-2022-be776dbf04 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-be776dbf04` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-be776dbf04 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-d6fde24a93 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-d6fde24a93` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d6fde24a93 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-be776dbf04 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-d6fde24a93 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. |