Bug 2118180 - Review Request: external-editor-revived - Thunderbird extension that allows editing emails in external editors such as Vim
Summary: Review Request: external-editor-revived - Thunderbird extension that allows e...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-08-14 19:15 UTC by Dusty Mabe
Modified: 2022-12-23 01:20 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-12-23 01:19:42 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Dusty Mabe 2022-08-14 19:15:17 UTC
Spec URL: https://dustymabe.fedorapeople.org/external-editor-revived.spec
SRPM URL: https://dustymabe.fedorapeople.org/external-editor-revived-0.4.0-1.fc37.src.rpm
Description: Thunderbird extension that allows editing emails in external editors such as Vim
Fedora Account System Username: dustymabe

Comment 1 Dusty Mabe 2022-08-14 19:16:06 UTC
Upstream URL of the project: https://github.com/Frederick888/external-editor-revived

Comment 2 Robert-André Mauchin 🐧 2022-08-15 00:53:23 UTC
 - You should use %global here too:

%define thunderbird_app_id \{3550f703-e582-4d05-9a08-453d09bdfdc6\}
%define extensions_dir %{_libdir}/mozilla/extensions/%{thunderbird_app_id}

 - don't use macros starting with __, they are for RPM internal use

%{__mkdir_p} $RPM_BUILD_ROOT%{_libdir}/mozilla/native-messaging-hosts

%{__mkdir_p} $RPM_BUILD_ROOT%{extensions_dir}

Comment 3 Dusty Mabe 2022-08-15 03:01:36 UTC
Thanks!

I fixed both of those issues and updated the links.

Comment 4 Robert-André Mauchin 🐧 2022-08-15 08:47:06 UTC
 - License ok
 - Latest version packaged
 - Builds in mock
 - No tests available
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Comment 5 Fabio Valentini 2022-08-17 08:54:55 UTC
Side note: Since this package will contain a statically linked Rust binary, you'll need to update the license tag to take statically linked Rust components into account.

Comment 6 Tomas Hrcka 2022-08-26 10:37:18 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/external-editor-revived

Comment 7 Fabio Valentini 2022-10-13 12:42:15 UTC
Looks like you have not imported the package yet - please do that. :)

Comment 8 Dusty Mabe 2022-10-13 20:22:31 UTC
Yeah. To be honest I haven't had a chance to get back around to it. I think I had things ready to go but then https://bugzilla.redhat.com/show_bug.cgi?id=2118180#c5 happened and I haven't had a chance to figure that out yet.

It might be a few weeks.

Comment 9 Fabio Valentini 2022-10-13 20:52:38 UTC
You can use this command in the source directory in a mock chroot after a successful build:

cargo tree --workspace --offline --edges no-build,no-dev,no-proc-macro --no-dedupe --target all --prefix none --format "# {l}" | sed -e "s: / :/:g" -e "s:/: OR :g" | sort -u

This should print a list of all unique licenses that end up getting statically linked into your binary.

Comment 10 Fedora Update System 2022-12-14 22:21:27 UTC
FEDORA-2022-d6fde24a93 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d6fde24a93

Comment 11 Fedora Update System 2022-12-14 22:21:30 UTC
FEDORA-2022-be776dbf04 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-be776dbf04

Comment 12 Fedora Update System 2022-12-15 01:21:41 UTC
FEDORA-2022-be776dbf04 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-be776dbf04`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-be776dbf04

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-12-15 01:29:20 UTC
FEDORA-2022-d6fde24a93 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-d6fde24a93`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d6fde24a93

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-12-23 01:19:42 UTC
FEDORA-2022-be776dbf04 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2022-12-23 01:20:35 UTC
FEDORA-2022-d6fde24a93 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.