Bug 2119517

Summary:	[4.6.z clone] OSD Removal template needs to expose option to force remove the OSD
Product:	[Red Hat Storage] Red Hat OpenShift Container Storage	Reporter:	Travis Nielsen <tnielsen>
Component:	ocs-operator	Assignee:	Subham Rai <srai>
Status:	CLOSED ERRATA	QA Contact:	Itzhak <ikave>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.7	CC:	asriram, kramdoss, madam, muagarwa, ocs-bugs, rgeorge, sostapov, srai
Target Milestone:	---	Keywords:	ZStream
Target Release:	OCS 4.6.15
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:	With this update, you can set a flag, `true` or `false` to indicate whether the OSD can be forcefully removed or not. By default, the flag is set to `false` and this ensures that there is no data loss due to the accidental removal of the OSD. When the OSD removal fails and if you are sure that the OSD needs to be removed, then you set the flag to `true` and run the job again.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-09-28 14:31:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2106027
Bug Blocks:	2119519

Description Travis Nielsen 2022-08-18 17:28:04 UTC

This bug was initially created as a copy of Bug #2027826

I am copying this bug because: 

Requested for backport

This bug was initially created as a copy of Bug #2026007

I am copying this bug because: 

An OCS operator update is needed to expose an option to force removal of an OSD if Ceph indicates the OSD is not safe-to-destroy.

If https://bugzilla.redhat.com/show_bug.cgi?id=2027396 is approved for 4.9.z, we will also need this for 4.9.z.


Description of problem (please be detailed as possible and provide log
snippets):
Use ceph 'osd safe-to-destroy' and 'osd ok-to-stop' feature in OSD purge job

[1] mgr: implement 'osd safe-to-destroy' and 'osd ok-to-stop' commands
     https://github.com/ceph/ceph/pull/16976 
     An osd is safe to destroy if
we have osd_stat for it
osd_stat indicates no pgs stored
all pgs are known
no pgs map to it
i.e., overall data durability will not be affected
An OSD is ok to stop if

we have the pg stats we need
no PGs will drop below min_size
i.e., availability won't be immediately compromised

Comment 14 errata-xmlrpc 2022-09-28 14:31:28 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenShift OpenShift Container Storage 4.6.15 Bug Fix Update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:6738