Bug 2120450

Summary:	Review Request: golang-github-twpayne-vfs-3 - v3 import path of twpayne-vfs
Product:	[Fedora] Fedora	Reporter:	Anthony Rabbito <hello>
Component:	Package Review	Assignee:	Mikel Olasagasti Uranga <mikel>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	hello, mikel, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:	If this bug requires documentation, please select an appropriate Doc Type value.
Last Closed:	2022-10-05 23:18:07 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2120454

Description Anthony Rabbito 2022-08-23 02:01:35 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/anthr76/golang-to-fedora/fedora-rawhide-x86_64/04752709-golang-github-twpayne-vfs-3/golang-github-twpayne-vfs-3.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/anthr76/golang-to-fedora/fedora-rawhide-x86_64/04752709-golang-github-twpayne-vfs-3/golang-github-twpayne-vfs-3-3.0.0-1.fc38.src.rpm
Description: Package vfs provides an abstraction of the os and io packages that is easy to test.
Fedora Account System Username: anthr76/@GoSig

Comment 1 Anthony Rabbito 2022-09-28 22:48:28 UTC

Updated spec to use `gometa -f`

Spec URL: https://anthr76.fedorapeople.org/golang-github-twpayne-vfs-3/golang-github-twpayne-vfs-3.spec
SRPM URL: https://anthr76.fedorapeople.org/golang-github-twpayne-vfs-3/golang-github-twpayne-vfs-3-3.0.0-1.fc37.src.rpm

Comment 2 Mikel Olasagasti Uranga 2022-10-05 21:36:33 UTC

Spec is correct, but I've one doubt.

Diff between v3 and v4 has not any relevant change over previous version:

https://github.com/twpayne/go-vfs/compare/v3.0.0...v4.1.0

I've checked if xdg-v6 package could work with go-vfs-v4 and, as expected, works fine.

https://github.com/twpayne/go-xdg/pull/7

I see three options:

a) Package go-vfs-v3 as-is in this BZ
b) Package go-vfs-v4 and patch xdg-v6 to switch (sed or patch) from go-vfs-v3 to go-vfs-v4
c) Package go-vfs non versioned, and modify xdg-v6 spec to replace dependency of go-vfs

I would go with option b, so in case any other package depends on it can use the latest version, but as you prefer.

Comment 3 Mikel Olasagasti Uranga 2022-10-05 22:02:58 UTC

Now I see that chezmoi itself depends on go-vfs-v4 and that a review is pending for it: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2120452

Based on this, please, go with option b, close this BZ and we go with BZ2120452.

Comment 4 Anthony Rabbito 2022-10-05 23:18:07 UTC

Sure Mikel. We will go with option B

Thank you very much for the upstream patch. Cheers!