Bug 2120450 - Review Request: golang-github-twpayne-vfs-3 - v3 import path of twpayne-vfs
Summary: Review Request: golang-github-twpayne-vfs-3 - v3 import path of twpayne-vfs
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2120454
TreeView+ depends on / blocked
 
Reported: 2022-08-23 02:01 UTC by Anthony Rabbito
Modified: 2022-10-05 23:18 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
If this bug requires documentation, please select an appropriate Doc Type value.
Last Closed: 2022-10-05 23:18:07 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Comment 2 Mikel Olasagasti Uranga 2022-10-05 21:36:33 UTC
Spec is correct, but I've one doubt.

Diff between v3 and v4 has not any relevant change over previous version:

https://github.com/twpayne/go-vfs/compare/v3.0.0...v4.1.0

I've checked if xdg-v6 package could work with go-vfs-v4 and, as expected, works fine.

https://github.com/twpayne/go-xdg/pull/7

I see three options:

a) Package go-vfs-v3 as-is in this BZ
b) Package go-vfs-v4 and patch xdg-v6 to switch (sed or patch) from go-vfs-v3 to go-vfs-v4
c) Package go-vfs non versioned, and modify xdg-v6 spec to replace dependency of go-vfs

I would go with option b, so in case any other package depends on it can use the latest version, but as you prefer.

Comment 3 Mikel Olasagasti Uranga 2022-10-05 22:02:58 UTC
Now I see that chezmoi itself depends on go-vfs-v4 and that a review is pending for it: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2120452

Based on this, please, go with option b, close this BZ and we go with BZ2120452.

Comment 4 Anthony Rabbito 2022-10-05 23:18:07 UTC
Sure Mikel. We will go with option B

Thank you very much for the upstream patch. Cheers!


Note You need to log in before you can comment on or make changes to this bug.