Bug 2121984
| Summary: | Review Request: asahi-installer - Asahi Linux installer | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-09-19 16:36:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2121982, 2124298 | ||
| Bug Blocks: | |||
|
Description
Davide Cavalca
2022-08-28 04:24:25 UTC
Note that we're not packaging the whole installer here for the time being, just the firmware extraction logic. Spec URL: https://dcavalca.fedorapeople.org/review/asahi-installer/asahi-installer.spec SRPM URL: https://dcavalca.fedorapeople.org/review/asahi-installer/asahi-installer-0.4.1-1.fc38.src.rpm Changelog: - add Requires for lzfse-libs Taking this review. Spec review notes:
> Requires: lzfse-libs
Since you're dlopening the library with a patched soname, I'd recommend converting this requires to a library requires.
You can see an example of this in the SDL2 package for libdecor.
This is not mandatory to fix here, but I suggest you make this change when you import it.
Package review notes: * Package is named properly per packaging guidelines * Package builds and installs (once lzfse-libs is installed) * Package licensing is correct and license files are correctly installed * No serious issues from rpmlint PACKAGE APPROVED. Thanks! $ fedpkg request-repo asahi-installer 2121984 https://pagure.io/releng/fedora-scm-requests/issue/47605 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/asahi-installer FEDORA-2022-5ca2462912 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-5ca2462912 FEDORA-2022-5ca2462912 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. |