Bug 2121984 - Review Request: asahi-installer - Asahi Linux installer
Summary: Review Request: asahi-installer - Asahi Linux installer
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2121982 2124298
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-08-28 04:24 UTC by Davide Cavalca
Modified: 2022-09-19 16:36 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-09-19 16:36:47 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2022-08-28 04:24:25 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/asahi-installer/asahi-installer.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/asahi-installer/asahi-installer-0.4.1-1.fc38.src.rpm

Description:
Asahi Linux installer

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2022-08-28 04:25:19 UTC
Note that we're not packaging the whole installer here for the time being, just the firmware extraction logic.

Comment 3 Neal Gompa 2022-09-17 12:34:40 UTC
Taking this review.

Comment 4 Neal Gompa 2022-09-17 12:35:14 UTC
Spec review notes:

> Requires:       lzfse-libs

Since you're dlopening the library with a patched soname, I'd recommend converting this requires to a library requires.

You can see an example of this in the SDL2 package for libdecor.

This is not mandatory to fix here, but I suggest you make this change when you import it.

Comment 5 Neal Gompa 2022-09-17 12:36:10 UTC
Package review notes:

* Package is named properly per packaging guidelines
* Package builds and installs (once lzfse-libs is installed)
* Package licensing is correct and license files are correctly installed
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 6 Davide Cavalca 2022-09-17 12:39:51 UTC
Thanks!

$ fedpkg request-repo asahi-installer 2121984
https://pagure.io/releng/fedora-scm-requests/issue/47605

Comment 7 Gwyn Ciesla 2022-09-19 14:04:48 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/asahi-installer

Comment 8 Fedora Update System 2022-09-19 16:33:51 UTC
FEDORA-2022-5ca2462912 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-5ca2462912

Comment 9 Fedora Update System 2022-09-19 16:36:47 UTC
FEDORA-2022-5ca2462912 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.