Bug 2122345
| Summary: | Review Request: credentials-fetcher - Daemon to allow Windows gMSA accounts to be used in Linux | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Samiullah Mohammed <samiull> |
| Component: | Package Review | Assignee: | Tom "spot" Callaway <spotrh> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, spotrh |
| Target Milestone: | --- | Flags: | spotrh:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-09-01 09:40:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Samiullah Mohammed
2022-08-29 20:13:25 UTC
Updated SRPM - https://s3.us-west-2.amazonaws.com/aws.portingassistant.dotnet.datastore/credentials-fetcher-0.0.94-1.fc36.src.rpm There are some extremely minor issues in the spec, which we can fix after import: 1. License: tag should be "Apache-2.0" 2. When you commit the spec file to Fedora packaging git, please rename it to "credentials-fetcher.spec" 3. One of the %description lines is longer than 80 characters (just fix it to wrap around): Kerberos tickets are refreshed when tickets expire or when a gMSA password changes. 4. Summary is not capitalized, but given that the name of the project is not, this is not an issue. 5. You may want to consider including the release value at the end of the version string in changelog entries, like this, since you may want to update release when version has not changed. This is not required though. * Mon Aug 29 2022 Tom Callaway <spotaws> - 0.0.94-1 All other rpmlint issues are safe to ignore: credentials-fetcher-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/sbin/credentials-fetcherd-0.0.94-1.fc36.x86_64.debug credentials-fetcher-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/sbin/credentials-fetcherd-0.0.94-1.fc36.x86_64.debug credentials-fetcher.x86_64: E: non-standard-executable-perm /usr/sbin/credentials_fetcher_utf16_private.exe 700 credentials-fetcher.x86_64: E: non-readable /usr/sbin/credentials_fetcher_utf16_private.exe 700 credentials-fetcher.x86_64: W: no-manual-page-for-binary credentials-fetcherd credentials-fetcher.x86_64: W: no-manual-page-for-binary credentials_fetcher_utf16_private.exe credentials-fetcher-debuginfo.x86_64: W: no-documentation credentials-fetcher-debugsource.x86_64: W: no-documentation credentials-fetcher.x86_64: W: name-repeated-in-summary credentials-fetcher credentials-fetcher.src: W: name-repeated-in-summary credentials-fetcher credentials-fetcher.x86_64: W: incoherent-version-in-changelog 0.0.94 ['0.0.94-1.fc36', '0.0.94-1'] = Review = - package meets naming guidelines - package meets packaging guidelines - license (Apache 2.0) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on F36 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok (the mono bits are weird, but necessary) - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/credentials-fetcher FEDORA-2022-49a649fe54 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-49a649fe54 FEDORA-2022-a7bd44e159 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a7bd44e159 FEDORA-2022-7dd06cefe9 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-7dd06cefe9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-7dd06cefe9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-a7bd44e159 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-a7bd44e159 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-a7bd44e159 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-49a649fe54 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-49a649fe54 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-49a649fe54 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-49a649fe54 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-a7bd44e159 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-7dd06cefe9 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. |