Bug 2122345 - Review Request: credentials-fetcher - Daemon to allow Windows gMSA accounts to be used in Linux
Summary: Review Request: credentials-fetcher - Daemon to allow Windows gMSA accounts t...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-08-29 20:13 UTC by Samiullah Mohammed
Modified: 2022-09-12 17:43 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-09-01 09:40:41 UTC
Type: ---
Embargoed:
spotrh: fedora-review+


Attachments (Terms of Use)

Description Samiullah Mohammed 2022-08-29 20:13:25 UTC
Spec URL: https://s3.us-west-2.amazonaws.com/aws.portingassistant.dotnet.datastore/credentials-fetcher-fedora.spec
SRPM URL: https://s3.us-west-2.amazonaws.com/aws.portingassistant.dotnet.datastore/credentials-fetcher-0.0.93-1.fc36.src.rpm
Description: This daemon creates and refreshes kerberos tickets, these tickets can be used to launch new containers. The gMSA feature can be implemented using this daemon.
Kerberos tickets are refreshed when tickets expire or when a gMSA password changes.
The same method can be used to refresh other types of security tokens.

Fedora Account System Username:samiullahmohammed

Comment 2 Tom "spot" Callaway 2022-08-29 20:35:12 UTC
There are some extremely minor issues in the spec, which we can fix after import:

1. License: tag should be "Apache-2.0"
2. When you commit the spec file to Fedora packaging git, please rename it to "credentials-fetcher.spec"
3. One of the %description lines is longer than 80 characters (just fix it to wrap around):

   Kerberos tickets are refreshed when tickets expire or when a gMSA password changes.

4. Summary is not capitalized, but given that the name of the project is not, this is not an issue.
5. You may want to consider including the release value at the end of the version string in changelog entries, like this, since you may want to update release when version has not changed.
   This is not required though.

 * Mon Aug 29 2022 Tom Callaway <spotaws> - 0.0.94-1

All other rpmlint issues are safe to ignore:

credentials-fetcher-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/sbin/credentials-fetcherd-0.0.94-1.fc36.x86_64.debug
credentials-fetcher-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/sbin/credentials-fetcherd-0.0.94-1.fc36.x86_64.debug
credentials-fetcher.x86_64: E: non-standard-executable-perm /usr/sbin/credentials_fetcher_utf16_private.exe 700
credentials-fetcher.x86_64: E: non-readable /usr/sbin/credentials_fetcher_utf16_private.exe 700
credentials-fetcher.x86_64: W: no-manual-page-for-binary credentials-fetcherd
credentials-fetcher.x86_64: W: no-manual-page-for-binary credentials_fetcher_utf16_private.exe
credentials-fetcher-debuginfo.x86_64: W: no-documentation
credentials-fetcher-debugsource.x86_64: W: no-documentation
credentials-fetcher.x86_64: W: name-repeated-in-summary credentials-fetcher
credentials-fetcher.src: W: name-repeated-in-summary credentials-fetcher
credentials-fetcher.x86_64: W: incoherent-version-in-changelog 0.0.94 ['0.0.94-1.fc36', '0.0.94-1']

= Review =
- package meets naming guidelines
- package meets packaging guidelines
- license (Apache 2.0) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on F36 (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok (the mono bits are weird, but necessary)
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED

Comment 3 Gwyn Ciesla 2022-08-29 22:03:10 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/credentials-fetcher

Comment 4 Fedora Update System 2022-08-30 17:22:55 UTC
FEDORA-2022-49a649fe54 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-49a649fe54

Comment 5 Fedora Update System 2022-08-30 17:22:56 UTC
FEDORA-2022-a7bd44e159 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a7bd44e159

Comment 6 Fedora Update System 2022-08-31 02:22:01 UTC
FEDORA-2022-7dd06cefe9 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-7dd06cefe9 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-7dd06cefe9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2022-08-31 09:48:35 UTC
FEDORA-2022-a7bd44e159 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-a7bd44e159 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-a7bd44e159

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2022-08-31 09:57:42 UTC
FEDORA-2022-49a649fe54 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-49a649fe54 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-49a649fe54

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2022-09-01 09:40:41 UTC
FEDORA-2022-49a649fe54 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2022-09-01 09:55:14 UTC
FEDORA-2022-a7bd44e159 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2022-09-12 17:43:07 UTC
FEDORA-2022-7dd06cefe9 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.