Bug 2122368
| Summary: | Review Request: golang-github-alecthomas-chroma-2 - A general purpose syntax highlighter in pure Go | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | W. Michael Petullo <mike> |
| Component: | Package Review | Assignee: | Mark E. Fuller <mark.e.fuller> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mark.e.fuller, mikel, package-review |
| Target Milestone: | --- | Flags: | mark.e.fuller:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-10-26 16:00:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1930952 | ||
|
Description
W. Michael Petullo
2022-08-29 21:19:47 UTC
> install -m 0755 -vp %{gobuilddir}/src/github.com/alecthomas/chroma/v2/lexers/embedded/* %{buildroot}%{_datarootdir}/gocode/src/github.com/alecthomas/chroma/lexers/embedded Shouldn't these files be 0644? > # lexers: requires github.com/alecthomas/repr, which is not in Fedora yet > %gocheck -d lexers Do you plan to add `repr`? If so, it would be great to do it in advance, just block this BZ with the other review. I fixed the permissions. You are right that they should be 0644. I do not think repr is strictly required for chroma, even though one of the unit tests requires it. My aim is to fulfill the dependencies of the latest Hugo release. v2.3.0 was released last month. Would you please update the spec and srpm? Spec URL: https://www.flyn.org/SRPMS/golang-github-alecthomas-chroma-2.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-alecthomas-chroma-2-2.3.0-1.fc36.src.rpm Description: A general purpose syntax highlighter in pure Go. Fedora Account System Username: mikep Updated to 2.3.0. Spec is autogenerated with go2rpm with some modifications: - License ok - Latest version packaged - Builds in mock - Check passes - No rpmlint errors - Conforms to Packaging Guidelines Approved Spec is autogenerated with go2rpm with some modifications: - License ok - Latest version packaged - Builds in mock - Check passes - No rpmlint errors - Conforms to Packaging Guidelines Approved (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-alecthomas-chroma-2 |