Bug 2122368 - Review Request: golang-github-alecthomas-chroma-2 - A general purpose syntax highlighter in pure Go
Summary: Review Request: golang-github-alecthomas-chroma-2 - A general purpose syntax ...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mark E. Fuller
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1930952
TreeView+ depends on / blocked
 
Reported: 2022-08-29 21:19 UTC by W. Michael Petullo
Modified: 2022-10-26 16:00 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-10-26 16:00:05 UTC
Type: ---
Embargoed:
mark.e.fuller: fedora-review+


Attachments (Terms of Use)

Description W. Michael Petullo 2022-08-29 21:19:47 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-alecthomas-chroma-2.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-alecthomas-chroma-2-2.2.0-1.fc36.src.rpm
Description: A general purpose syntax highlighter in pure Go.
Fedora Account System Username: mikep

Comment 1 Mikel Olasagasti Uranga 2022-08-29 21:48:23 UTC
> install -m 0755 -vp %{gobuilddir}/src/github.com/alecthomas/chroma/v2/lexers/embedded/* %{buildroot}%{_datarootdir}/gocode/src/github.com/alecthomas/chroma/lexers/embedded

Shouldn't these files be 0644?

> # lexers: requires github.com/alecthomas/repr, which is not in Fedora yet
> %gocheck -d lexers

Do you plan to add `repr`? If so, it would be great to do it in advance, just block this BZ with the other review.

Comment 2 W. Michael Petullo 2022-08-30 14:36:11 UTC
I fixed the permissions. You are right that they should be 0644.

I do not think repr is strictly required for chroma, even though one of the unit tests requires it. My aim is to fulfill the dependencies of the latest Hugo release.

Comment 3 Mark E. Fuller 2022-10-23 19:55:12 UTC
v2.3.0 was released last month.
Would you please update the spec and srpm?

Comment 4 W. Michael Petullo 2022-10-23 20:40:31 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-alecthomas-chroma-2.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-alecthomas-chroma-2-2.3.0-1.fc36.src.rpm
Description: A general purpose syntax highlighter in pure Go.
Fedora Account System Username: mikep

Updated to 2.3.0.

Comment 5 Mark E. Fuller 2022-10-25 18:05:59 UTC
Spec is autogenerated with go2rpm with some modifications: 

 - License ok
 - Latest version packaged
 - Builds in mock
 - Check passes
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Approved

Comment 6 Mark E. Fuller 2022-10-25 18:06:29 UTC
Spec is autogenerated with go2rpm with some modifications: 

 - License ok
 - Latest version packaged
 - Builds in mock
 - Check passes
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Approved

Comment 7 Tomas Hrcka 2022-10-26 14:03:48 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-alecthomas-chroma-2


Note You need to log in before you can comment on or make changes to this bug.