Bug 2124317

Summary:	Review Request: rust-cssparser-macros - Procedural macros for cssparser
Product:	[Fedora] Fedora	Reporter:	Kalev Lember <klember>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rust-cssparser-macros-0.6.0-7.fc38	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-09-09 08:29:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2124329

Description Kalev Lember 2022-09-05 16:18:43 UTC

Spec URL: https://kalev.fedorapeople.org/rust-cssparser-macros.spec
SRPM URL: https://kalev.fedorapeople.org/rust-cssparser-macros-0.6.0-7.fc38.src.rpm
Description: Procedural macros for cssparser.
Fedora Account System Username: kalev

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=91667349

This is a re-review to of a retired package, one that is needed for building librsvg2. My goal here is to switch librsvg2 to build against Fedora packaged crates instead of the vendored rust crates it's using now.

Comment 1 Fabio Valentini 2022-09-05 16:36:28 UTC

Package was (re-)generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass (there are no tests)
- latest version of the crate is packaged
- license matches upstream specification (MPL-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.
Thanks for working on unbundling stuff from librsvg2!

Comment 2 Kalev Lember 2022-09-05 16:38:36 UTC

Awesome, thank you for the super quick review!

Comment 3 Kalev Lember 2022-09-05 16:44:46 UTC

Releng unretirement ticket: https://pagure.io/releng/issue/11012

Comment 4 Kalev Lember 2022-09-09 08:29:32 UTC

OK, unretirement is done and package is building in rawhide and I've requested branches for F37.