Spec URL: https://kalev.fedorapeople.org/rust-cssparser.spec SRPM URL: https://kalev.fedorapeople.org/rust-cssparser-0.28.1-4.fc38.src.rpm Description: Rust implementation of CSS Syntax Level 3. Fedora Account System Username: kalev This is a re-review of a retired package, one that is needed for building librsvg2. My goal here is to switch librsvg2 to build against Fedora packaged crates instead of the vendored rust crates it's using now. Note that this depends on two other re-reviews, rust-cssparser-macros and rust-dtoa-short. The package builds fine locally in mock against locally-built rust-cssparser-macros and rust-dtoa-short. Also note that I'm only unretiring the package and I've deliberately left it at version 0.28.1 that the package was before retirement and haven't updated it to 0.29.6. The reason for this is that librsvg currently needs 0.28.x and it seems a bit weird to unretire this package because of librsvg, but include an incompatible version update to 0.29.6 and then immediately have to create a compat rust-cssparser0.28 package, which would mean that nothing in Fedora uses rust-cssparser again.
> The reason for this is that librsvg currently needs 0.28.x Yeah this is completely fine. We usually only update library-only crates to incompatible versions when something actually starts to depend on the new version, exactly because it would make no sense to create a compat package and then have the non-compat package be unused. I'll review this package once the other dependencies are built in rawhide, if that's okay with you. But if you're in a hurry, I can also do the review with locally built dependencies.
I'm in no hurry at all. Thanks!
OK, dependencies are all built in rawhide now. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=91827537
Sorry for the delay. The notification that this is ready got lost in my inbox. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass (only doctests, as test fixtures for unit tests are not included in published crates) - latest (possible) version of the crate is packaged (librsvg2 still requires v0.28.x) - license matches upstream specification ( and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches
Meh, I pressed "Submit" too fast. Just skip the post-import tasks that aren't applicable because this is an un-retirement and not a new package :)
Awesome, thank you! Releng unretirement request: https://pagure.io/releng/issue/11056
Package unretired and built.