Bug 2124359

Summary:	Review Request: rust-rctree - 'DOM-like' tree implemented using reference counting
Product:	[Fedora] Fedora	Reporter:	Kalev Lember <klember>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rust-rctree-0.4.0-1.fc38	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-09-07 10:51:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Kalev Lember 2022-09-05 19:45:46 UTC

Spec URL: https://kalev.fedorapeople.org/rust-rctree.spec
SRPM URL: https://kalev.fedorapeople.org/rust-rctree-0.4.0-1.fc38.src.rpm

Description:
'DOM-like' tree implemented using reference counting.

Fedora Account System Username: kalev

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=91673763

rust-rctree is a dependency for librsvg2 (I'm trying to get it to build using system rust creates instead of vendored).

Comment 1 Fabio Valentini 2022-09-05 20:38:11 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

===

Please take care not to "fedpkg import" the SRPM file that was already mangled by rpmautospec.

Comment 2 Kalev Lember 2022-09-06 07:38:38 UTC

Thanks for the review! Sure, will do as soon as the repo is created.

Comment 3 Gwyn Ciesla 2022-09-06 16:08:23 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rctree

Comment 4 Kalev Lember 2022-09-07 10:51:29 UTC

Package imported and built. I've set up a new project on release-monitoring.org as well and set the bugzilla overrides. Thanks for all the help with this!