Bug 2124359 - Review Request: rust-rctree - 'DOM-like' tree implemented using reference counting
Summary: Review Request: rust-rctree - 'DOM-like' tree implemented using reference cou...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-09-05 19:45 UTC by Kalev Lember
Modified: 2022-09-07 10:51 UTC (History)
2 users (show)

Fixed In Version: rust-rctree-0.4.0-1.fc38
Clone Of:
Environment:
Last Closed: 2022-09-07 10:51:29 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Kalev Lember 2022-09-05 19:45:46 UTC
Spec URL: https://kalev.fedorapeople.org/rust-rctree.spec
SRPM URL: https://kalev.fedorapeople.org/rust-rctree-0.4.0-1.fc38.src.rpm

Description:
'DOM-like' tree implemented using reference counting.

Fedora Account System Username: kalev

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=91673763

rust-rctree is a dependency for librsvg2 (I'm trying to get it to build using system rust creates instead of vendored).

Comment 1 Fabio Valentini 2022-09-05 20:38:11 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

===

Please take care not to "fedpkg import" the SRPM file that was already mangled by rpmautospec.

Comment 2 Kalev Lember 2022-09-06 07:38:38 UTC
Thanks for the review! Sure, will do as soon as the repo is created.

Comment 3 Gwyn Ciesla 2022-09-06 16:08:23 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rctree

Comment 4 Kalev Lember 2022-09-07 10:51:29 UTC
Package imported and built. I've set up a new project on release-monitoring.org as well and set the bugzilla overrides. Thanks for all the help with this!


Note You need to log in before you can comment on or make changes to this bug.