Bug 2124361
| Summary: | Review Request: rust-servo_arc - Fork of std::sync::Arc with some extra functionality and without weak references | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kalev Lember <klember> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rust-servo_arc-0.1.1-2.fc38 rust-servo_arc-0.1.1-2.fc37 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-10-13 18:44:59 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2124365 | ||
|
Description
Kalev Lember
2022-09-05 20:01:22 UTC
> # license file is missing from the crate In the case of MIT and Apache-2.0 licenses, this is actually a problem. Both require redistributed sources to ship a copy of the license text. There are no license files in the upstream repo for this crate, either: https://github.com/servo/servo/tree/master/components/servo_arc But some crates in the /components/ directory seem to have LICENSE-MIT and LICENSE-Apache files, so filing an issue with the project should hopefully get this resolved. * Sat Oct 01 2022 Kalev Lember <klember> 0.1.1-2 - Backport upstream patch to add license files (rhbz#2124361) Spec URL: https://kalev.fedorapeople.org/rust-servo_arc.spec SRPM URL: https://kalev.fedorapeople.org/rust-servo_arc-0.1.1-2.fc38.src.rpm Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=92464208 Sorry for the delay. Package looks good to me now, thanks for filing the upstream issue. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches Thanks, Fabio! (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-servo_arc FEDORA-2022-acfeadddbd has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-acfeadddbd FEDORA-2022-acfeadddbd has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. Package imported and built. |